Bug 145439 - Huge memory leak in DiagramEditor
Summary: Huge memory leak in DiagramEditor
Status: RESOLVED DUPLICATE of bug 142803
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major
Target Milestone: 1.0   Edit
Assignee: Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2006-06-05 18:50 EDT by Maneesh CLA
Modified: 2010-07-19 12:30 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maneesh CLA 2006-06-05 18:50:47 EDT 
In the startListening code of DiagramEditor registers a DiagramEventBrokerThreadSafe, but in stopListeneing it is never unregistered.

The DiagramEventBrokerThreadSafe keeps a reference to Editor, which itself keeps reference to diagram and to semantic model. Even after closing the editor, none of these are released.
Comment 1 Frederic Plante CLA 2006-06-05 19:35:39 EDT 
Should be fixed in RC5
Comment 2 Steven R. Shaw CLA 2006-06-06 08:48:35 EDT 
It doesn't call stopListening by design since many Editors can share the same editing domain.  The DiagramEventBroker holds all references through weak hash map and weak references.

Regarding the reference to Editor, I think you must be still looking at the older GMF where the DiagramEventBrokerThreadSafe was declared as a non-static inner class.  This is no longer the case in the latest target.

*** This bug has been marked as a duplicate of 142803 ***
Comment 3 Richard Gronback CLA 2008-08-13 13:05:49 EDT 
[target cleanup] 1.0 RC5 was the original target milestone for this bug
Comment 4 Eclipse Webmaster CLA 2010-07-19 12:30:11 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug