Bug 144531 - DeferredLayoutCommand keeps a reference to layoutcmd and never uses it for undo redo.
Summary: DeferredLayoutCommand keeps a reference to layoutcmd and never uses it for un...
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal
Target Milestone: 1.0.1   Edit
Assignee: Steven R. Shaw CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2006-05-30 15:55 EDT by Maneesh CLA
Modified: 2010-07-19 12:25 EDT (History)
0 users

See Also:

Attachments
patch for DeferredLayoutCommand (1.28 KB, patch)
2006-06-06 09:55 EDT, Steven R. Shaw CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maneesh CLA 2006-05-30 15:55:37 EDT 
DeferredLayoutCommand keeps a reference to layoutCmd used during execution and never nullifies this reference.
Since DeferredLayoutCommand is a TransactionalCommand and uses emf recording to undo redo, there is no need to keep reference to layoutCmd and can be nullified in the cleanup method.

This will save a lot of memory when working with the same diagram for a long time.
Comment 1 Steven R. Shaw CLA 2006-06-06 09:55:31 EDT 
Created attachment 43586 [details]
patch for DeferredLayoutCommand

Removed layoutCmd from state and made a local variable.  Targetting for 1.0.1
Comment 2 Anthony Hunter CLA 2006-07-12 12:45:28 EDT 
Steve, can you commit for 1.0.1?
Comment 3 Steven R. Shaw CLA 2006-07-13 17:49:28 EDT 
Committed patch to R1_0_maintenance stream
Comment 4 Eclipse Webmaster CLA 2010-07-19 12:25:44 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug