Bug 143937 - [TabbedProperties] Memory leak in PropertiesBrowserPage
Summary: [TabbedProperties] Memory leak in PropertiesBrowserPage
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 major
Target Milestone: 1.0   Edit
Assignee: Anthony Hunter CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2006-05-26 08:53 EDT by Dusko CLA
Modified: 2010-07-19 21:55 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dusko CLA 2006-05-26 08:53:56 EDT 
There is a memory leak in org.eclipse.gmf.runtime.diagram.ui.properties.views.PropertiesBrowserPage. Its dispose method does not actually clean up the fields and as long as the page is referenced somewhere else it references other objects. The most problematic object that it references is 'contributor' - very often it is a workbench part (view or editor) and can be really expensive.

This memory leak actualy builds on top of the memory leak in the base class (bug 143935). Please note that both classes have private field 'contributor' of the same type. This redundancy should be addressed as well.
Comment 1 Steven R. Shaw CLA 2006-05-26 09:03:05 EDT 
Anthony - can you have a look at this?
Comment 2 Anthony Hunter CLA 2006-06-13 11:19:48 EDT 
Added:
        /**
         * Clean up
         */
        contributor = null;
        selectedElements = null;

Will clean futher when adopting Bug 143935 .
Comment 3 Richard Gronback CLA 2008-08-13 13:05:45 EDT 
[target cleanup] 1.0 RC5 was the original target milestone for this bug
Comment 4 Eclipse Webmaster CLA 2010-07-19 21:55:11 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Common was the original product and component for this bug