Bug 143930 - create constructor ipe in same was as method ipes
Summary: create constructor ipe in same was as method ipes
Status: RESOLVED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: DEVELOPMENT   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 1.5.2   Edit
Assignee: Helen Beeken CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-26 07:12 EDT by Helen Beeken CLA
Modified: 2006-05-30 06:02 EDT (History)
0 users

See Also:


Attachments
proposed fix (3.84 KB, application/zip)
2006-05-26 10:00 EDT, Helen Beeken CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Helen Beeken CLA 2006-05-26 07:12:00 EDT
At the moment the way the constructor ipes are constructed is different to that of methods. For example, for a method which has signature

public void myMethod(String s, int i)

the corresponding ipe is firstly constructed with name "myMethod" and then the arguments are added. Adding the arguments results in an ipe with name "myMethod(java.lang.String,int)".

With a constructor that has signature

public MyClass(String s, int i)

the corresponding ipe is constructed with name "MyClass(String,int)" and no arguments are associated with it. 

Up until now there hasn't been a use case to change this. However, due to enhancement bug 141730 (updating handles not to rely on source locations) it is necessary for the constructor ipes to have arguments associated with them. Also, if the ipes of methods and constructors had similar properties then the processing for creating the new handles can be the same.
Comment 1 Helen Beeken CLA 2006-05-26 10:00:10 EDT
Created attachment 42704 [details]
proposed fix

This zip file contains four patches:

- pr143930-ajdoc-patch.txt: apply to the ajdoc project
- pr143930-ajdt-core-patch.txt: apply to the org.aspectj.ajdt.core project
- pr143930-tests-patch.txt: apply to the tests project
- pr143930-weaver-patch.txt: apply to the weaver project

Along with the fix for the current bug, this contains the modified fix to bug 143924 mentioned in that bug report along with the test also supplied in that bug report.
Comment 2 Andrew Clement CLA 2006-05-30 06:02:50 EDT
patches committed.