Bug 143872 - annotationProcessorFactory extension point schema incomplete
Summary: annotationProcessorFactory extension point schema incomplete
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: APT (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.1   Edit
Assignee: Walter Harley CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-25 20:05 EDT by Markus Keller CLA
Modified: 2006-07-12 19:43 EDT (History)
2 users (show)

See Also:

Attachments
Fix to extension point schema (3.04 KB, patch)
2006-05-30 20:11 EDT, Walter Harley CLA 		no flags Details | Diff
Updated patch to extension schema (3.04 KB, patch)
2006-05-30 20:28 EDT, Walter Harley CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2006-05-25 20:05:32 EDT 
N20060525-0010

The schema for org.eclipse.jdt.apt.core's annotationProcessorFactory extension point is incomplete (and maybe even wrong):

* 'factory > class' attribute should have:
- Type: 'java' (not 'string') and
- Extends: 'com.sun.mirror.apt.AnnotationProcessorFactory'

Without these meta attributes, PDE cannot properly support contributors:
- 'Rename Type' refactorings and Java search don't find/update references in plugin.xml
- no validation of contributed processor factory classes
- no help for creating new processor factories

* 'factory > class' is optional -> shouldn't it be required?
* 'factory > implements' does not seem to be used for anything -> remove?
* boilerplate "[Enter description of ..." and empty documentation in a few places
Comment 1 Jess Garms CLA 2006-05-25 20:39:06 EDT 
Walter, can you put together a patch for this?
Comment 2 Walter Harley CLA 2006-05-30 20:11:51 EDT 
Created attachment 43038 [details]
Fix to extension point schema

Here's a patch for annotationProcessorFactory.  I notice that the same comments apply to o.e.jdt.core.compilationParticipant.exsd; I will open a separate bug for that.
Comment 3 Walter Harley CLA 2006-05-30 20:28:46 EDT 
Created attachment 43040 [details]
Updated patch to extension schema

Actually, the 'class' attribute should implement, not extend, AnnotationProcessorFactory.
Comment 4 Markus Keller CLA 2006-05-31 06:04:44 EDT 
Patch looks good.

> Actually, the 'class' attribute should implement, not extend,
> AnnotationProcessorFactory.

I guess you mean bug 143874? (Sorry, I should have added a link here...)
AFAICS, this only affects the presentation in the UI, not the .exsd document.
Comment 5 Jess Garms CLA 2006-05-31 12:25:27 EDT 
Targeting 3.2.1 for this.
Comment 6 Walter Harley CLA 2006-07-06 21:02:44 EDT 
Fixed in HEAD, needs to be merged to 3.2.1.

Note that since we didn't get this done in time for 3.2, I've left the "implements" attribute in place, but deprecated it.  That is different than the attached patches, which removed the attribute altogether.
Comment 7 Walter Harley CLA 2006-07-12 19:43:21 EDT 
Merged into 3.2.1 as of v20060712-1830