Bug 143619 - ParentAssignedViewmap makes wrong assumption about generated figure getters names
Summary: ParentAssignedViewmap makes wrong assumption about generated figure getters n...
Status: RESOLVED FIXED
Alias: None
Product: GMF-Tooling (ARCHIVED)
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.0   Edit
Assignee: Artem Tikhomirov CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-05-24 18:28 EDT by Michael Golubev CLA
Modified: 2010-07-19 22:21 EDT (History)
0 users

See Also:

Attachments
Fixes test that would be broken by fix for this scr (1.79 KB, patch)
2006-05-24 19:21 EDT, Michael Golubev CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Golubev CLA 2006-05-24 18:28:22 EDT 
Actually in the InnerClassViewmapProducer, when ParentAssignedViewmap is created it assumes that the name of generated getter is 

// XXX yet another assumption - getter name
// FIXME introduce feedback to FigureGenerator to let us know exact names
v.setGetterName("get" + CodeGenUtil.validJavaIdentifier(figure.getName()));

But template /children/Figure.javajet generates this getter with another naming strategy: 

/**
* @generated
*/
public <%=nextClassName%> getFigure<%=next.getName()%>() {
As a result, generated code for MindMap sample can not be compiled.
Comment 1 Michael Golubev CLA 2006-05-24 18:33:05 EDT 
Proposed fix for https://bugs.eclipse.org/bugs/show_bug.cgi?id=139148 contains the fix for this problem as well (by introducing of the NamingStrategy static utility class into the gmfgraph generation).

Is it required to separate patches for this and #139148 scrs.
Comment 2 Michael Golubev CLA 2006-05-24 19:21:04 EDT 
Created attachment 42520 [details]
Fixes test that would be broken by fix for this scr

While original patch for this scr is placed at the https://bugs.eclipse.org/bugs/show_bug.cgi?id=139248 it is additional patch for wrong tests for this issue.
Comment 3 Artem Tikhomirov CLA 2006-05-25 09:51:50 EDT 
(In reply to comment #2)

> While original patch for this scr is placed at the
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=139248

Correct link is:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=139148
Comment 4 Artem Tikhomirov CLA 2006-06-25 14:12:20 EDT 
Introduce feedback from figure codegen and refactor viewmap producer not to use hardcoded pattern
Comment 5 Artem Tikhomirov CLA 2007-06-18 09:25:23 EDT 
With ChildAccess introduced, accessors are no longer hardcoded
Comment 6 Eclipse Webmaster CLA 2010-07-19 22:21:42 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Generation was the original product and component for this bug