Bug 143046 - There is no visual cue that the diagram editor is selected when navigating with the keyboard
Summary: There is no visual cue that the diagram editor is selected when navigating wi...
Status: RESOLVED WONTFIX
Alias: None
Product: GEF
Classification: Tools
Component: GEF-Legacy GEF (MVC) (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: gef-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-22 15:07 EDT by Cherie Revells CLA
Modified: 2010-04-05 16:09 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Cherie Revells CLA 2006-05-22 15:07:56 EDT
To navigate into a diagram so that you can work with the shapes on the diagram, you do the following:
- Press tab until the diagram editor tab is underlined or make the editor focused in some other way.
- Press tab to highlight "palette".
- Press tab again to higlight palette minimize button.
- Press tab again to select palette tools.
- Press tab again and now if you press arrow keys or the shift F10 you will see that the diagram is selected.
ISSUE#1:  The problem is that there is no visual cue to show that the diagram is selected (as far as I can tell).  I have always found this very confusing as have a number of others I have talked with that have been doing accessibility testing on our diagram editors.
ISSUE#2:  JAWS and Inspect Objects also does not seem to have any information as to what is selected.
Comment 1 Randy Hudson CLA 2006-05-22 15:30:25 EDT
For the same reason as GEF, an SWT Canvas does not change its visualization when it has focus. You don't know what the client is doing. Some GEF clients are creating text editors, and a blinking Caret already appears when their editor has focus. So, no additional affordance is required for those clients.

This has been requested before, but no one has provided a mockup of what the affordance would look like. I don't know of anything in other applications, so we need some direction here before we could provide an optional focus visualization.

ISSUE #2 is probably not valid since the contents editpart has the opportunity to provide information to accessibility clients.
Comment 2 Anthony Hunter CLA 2008-04-17 12:42:11 EDT
Hi Cherie, is this still a problem?

This bug got listed on the IBM Accessibility defects to be solved for 3.4.
Comment 3 Cherie Revells CLA 2008-04-17 13:07:25 EDT
Yes, this is still a problem.  I guess we first need to decide how we want to show the feedback.  What about drawing a rectangle just inside the diagram's viewport?
Comment 4 Randy Hudson CLA 2008-04-17 14:16:13 EDT
We solved this in some of our diagrams by changing the selection move handle (the thin line around the part, not the B&White resize squares) to be a different color based on focus:

- LIST_BACKGROUND_SELECTED (e.g. dark blue) when in focus
- BUTTON_BACKGROUND (e.g. gray) when not in focus
Comment 5 Cherie Revells CLA 2008-04-17 14:53:59 EDT
Randy, do you mean the line that is normally light blue that goes around the diagram editor and palette?  If so, that sounds good if it worked for you guys.  Can you point me which code I need to change?
Comment 6 Pratik Shah CLA 2008-04-17 15:16:39 EDT
(In reply to comment #4)
> We solved this in some of our diagrams by changing the selection move handle
This will still be a problem if nothing in the diagram is selected.

> Randy, do you mean the line that is normally light blue that goes around
> the diagram editor and palette?
No, he means the handles that appear when you select something in the diagram.
Comment 7 Anthony Hunter CLA 2008-04-22 14:25:25 EDT
It is clear that this issue can be resolved by clients. It is not clear what we have a proposal as a standard for graphical editors.

I am removing the accessibility keyword, as it does not actually block the accessibility of graphical editors based on GEF. 

We will leave open as an enhancement however.
Comment 8 Anthony Hunter CLA 2010-04-05 16:09:51 EDT
(In reply to comment #7)
> It is clear that this issue can be resolved by clients. It is not clear what we
> have a proposal as a standard for graphical editors.
> 
> I am removing the accessibility keyword, as it does not actually block the
> accessibility of graphical editors based on GEF. 
> 
> We will leave open as an enhancement however.

There is not much point to leaving this open. 

To conclude when the diagram is selected in the GEF Shapes Example:

(In reply to comment #0)
> ISSUE#1:  The problem is that there is no visual cue to show that the diagram
> is selected (as far as I can tell).  I have always found this very confusing as
> have a number of others I have talked with that have been doing accessibility
> testing on our diagram editors.

Inspect32 correctly shows that the diagram is selected.
JAWS does not report the diagram being selected.

> ISSUE#2:  JAWS and Inspect Objects also does not seem to have any information
> as to what is selected.

Inspect32 shows that the Name and Value is none (nothing).
JAWS does not report what is selected.

Both of these issues can be resolved and have been resolved by editors based on GEF.