Community
Participate
Working Groups
While investigating the fonts in WTP's preference pages in bug 128225, noticed that WTP's properties pages also don't always follow eclipse's dialog font. Some of these include: J2EE J2EE Module Dependencies JSP Fragment Project Facets Targeted Runtimes Validation Web Content Settings and there may be more..
Adding everyone from bug 128225.
Assigning to Amy so its assigned to a committer to track. I assumed this was assigned to David Schneider as a way of saying we'd love his continued patches for future fixes for Releaes 2.0? So .. I've marked as "help wanted" and in no way meant to discourage anyone!
This bug was assigned to David Schneider as I asked in bug 128225 if he'd be willing to tackle this problem and in comment 34 he said that he was willing to take this on. I don't think we need to assign bugs to committers. Contributors can handle bugs and prompt committers to review and commit when a patch is ready. I've cced david.schneider@unisys.com so he'll be able to track the changes and work with Amy. Amy, I'd encourage you to assign this bug back to David S., cc yourself and follow up with him on progress.
I did volunteer to take this bug. I'm not sure how much time I can devote to it. If you need it done by yesterday, then perhaps I'm not the best choice. Otherwise, I'd be happy to do it.
Thanks all for correcting me ... and explaining the history here. And, David, we do not "need yesterday" ... at this point, I'd say you have until next release :)
Right, I think this is a WTP 2.0 work item (as opposed to 1.5.1).
Sorry for the delay, but I'm FINALLY getting around to this. I'm almost complete, but I'm encountering the same problems as I did before. I can only generate patches for a few components. The majority of my changes I can't generate patches. see bug: 142726 Dave
Created attachment 50245 [details] First go at the patch Attached is the first go at the patch for this bugzilla. Question: In the patch my inserted code rarely lines up with the existing code, but it does in my running copy of the source. I'm not sure what to do. Should I be editing the patch? I'm not sure if the "+" occupies a real space location.
The patch I created has been sitting with no activity for well over a month. I'm sure that the patch no longer merges cleanly. When someone is availble to look at the patch and integrate it in a timely fashion, I am willing to spend some time to upgrade the patch to the current level of WTP. Thanks, Dave
Sorry for letting this slip through the cracks ... Amy, please see how this looks on WTP 2.0 stream.
Sorry for not applying these patches sooner. I was not able to use the patch as-is because apparently the project information was missing. I went through and added the project info, and then I was able to almost apply every change except for changes made to org.eclipse.jst.j2ee.ejb.annotation.ui (but I was able to figure out what was supposed to be changed, so I just did that manually) I did not make any changes to org.eclipse.wst.rdb because rdb turned into dtp, so a new defect should be opened on the data tools project for them to make their change. I also did not make any changes to org.eclipse.wst.wsdl.ui because that project has not branched yet, and they may still be doing work on 1.5.x. I opened a new defect on them (bug 163598) to track this outstanding issue. I believe J2EEPropertiesPage, JSP Fragment, Web Content Settings property pages were not updated with the font changes, so I fixed those up too. I think that's about it. I will attach a patch with the final results/changes. jst.ejb.ui jst.j2ee.ejb.annotations.ui jst.j2ee.jca.ui jst.j2ee.ui jst.jsp.ui jst.servlet.ui jst.ws.consumption.ui wst.command.env.ui wst.common.project.facet.ui wst.css.ui wst.html.ui wst.sse.ui wst.validation.ui wst.web.ui wst.xml.ui wst.xsd.ui
Created attachment 53333 [details] finalpatch.patch Changes made to all projects listed in the previous comment. Thanks Dave!
Thanks Amy. I'm sorry this was such a huge project to clean up for integration. I also have no idea why the project info was missing from the patch. I've been having great difficulty generating patches in the first place and end up taking my workspace home to generate patches. For future reference, if there is something I could have done better please let me know.
I believe your patches were fine except for the missing project info. It would look a little something like this: #P org.eclipse.wst.wsdl.ui Index: src-asd-wsdl11/org/eclipse/wst/wsdl/ui/internal/wizards/WSDLNewFileOptionsPage.java I'm not sure why your patch was missing those. If for some reason, you continue to have problems with your patch not including the project info, it'd be helpful if you add it manually. Or just generate a patch per project and make the patch filename the name of the project the patch is intended for. Thanks again. I've committed and released the changes to head for WTP 2.0. It should be in any build > 200611070200
verified on WTP2.0 SDK 200612180440
