Bug 142408 - TaglibIndex creates duplicate build path information
Summary: TaglibIndex creates duplicate build path information
Status: CLOSED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: jst.jsp (show other bugs)
Version: 1.5   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 1.5.1 M151   Edit
Assignee: Nitin Dahyabhai CLA
QA Contact: David Williams CLA
URL:
Whiteboard: PMC_approved
Keywords: performance
Depends on:
Blocks: 154971
  Show dependency tree
 
Reported: 2006-05-18 01:28 EDT by Nitin Dahyabhai CLA
Modified: 2006-09-27 13:52 EDT (History)
4 users (show)

See Also:

Attachments
proposed patch (44.79 KB, patch)
2006-09-06 16:04 EDT, Nitin Dahyabhai CLA 		no flags Details | Diff
updated patch (33.33 KB, patch)
2006-09-11 15:04 EDT, Nitin Dahyabhai CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nitin Dahyabhai CLA 2006-05-18 01:28:49 EDT 
In 1.5, if I have a web project A that includes another web project B in its build path, the internal project information for each one contains a complete set of records for taglibs found in the build path for B, once when A indexes B and then again if B is indexed by itself.  The time spent initially searching a project's build path is not insignificant, so this information needs to be reorganized to reduce the time spent indexing and the amount of memory it uses.
Comment 1 Nitin Dahyabhai CLA 2006-09-06 16:04:41 EDT 
Created attachment 49532 [details]
proposed patch

Attaching a patch that allows individual project descriptions to ask each other about tag libraries on their build path.
Comment 2 Nitin Dahyabhai CLA 2006-09-06 16:08:11 EDT 
Chuck, could you retry your import scenario with the attached patch?
Comment 3 Chuck Bridgham CLA 2006-09-06 23:19:03 EDT 
Reviewed and tested....

Solves my large workspace scenario....
Comment 4 Nitin Dahyabhai CLA 2006-09-11 15:04:16 EDT 
Created attachment 49869 [details]
updated patch

Updated to fix a problem with remembering required projects on
the build path in between sessions that was found while fleshing out the unit
tests.
Comment 5 David Williams CLA 2006-09-11 15:57:22 EDT 
+1
Comment 6 Tim Wagner CLA 2006-09-12 01:13:48 EDT 
+1
Comment 7 Naci Dai CLA 2006-09-12 10:05:52 EDT 
+1
Comment 8 Arthur Ryman CLA 2006-09-12 10:09:08 EDT 
+1 for WTP 1.5.1
Comment 9 Nitin Dahyabhai CLA 2006-09-12 21:07:59 EDT 
Fixed
Comment 10 Nitin Dahyabhai CLA 2006-09-27 13:52:41 EDT 
Verified in 1.5.1.  Closing.