Bug 141564 - list of messages in MessageHandler doesn't get cleared
Summary: list of messages in MessageHandler doesn't get cleared
Status: RESOLVED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: DEVELOPMENT   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.5.3   Edit
Assignee: Helen Beeken CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-12 11:46 EDT by Helen Beeken CLA
Modified: 2006-08-25 11:01 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Helen Beeken CLA 2006-05-12 11:46:15 EDT 
MessageHandler contains an ArrayList of the messages it handles within handleMessage(). This list doesn't appear to be cleared at any point.

Investigating bug 132314 and bug 126118 I'm running a development environment of eclipse containing several projects - two (which are completely unrelated projects) of which create errors. I have incremental building turned off and am triggering builds of the two projects via the build button. Whilst debugging I noticed that the messages list in MessageHandler has the messages for all the different failures which have happened in the two projects since I initialized the runtime workbench.
Comment 1 Andrew Clement CLA 2006-08-18 06:02:02 EDT 
see also bug 141556
Comment 2 Andrew Clement CLA 2006-08-23 08:32:18 EDT 
I think this is fixed now isnt it?
Comment 3 Helen Beeken CLA 2006-08-23 08:41:17 EDT 
Yes, this is now fixed and in the latest AJDT.

The problem was that in MessageHandlerAdapter.handleMessage(..) we were calling

    taskListManager.addSourcelineTask(message);
    return super.handleMessage(message); // also store...	

The first call was used by AJDT to add the message and the second was a redundant call which just stored the messages. These messages were not used or cleared. The fix was to return "true" without calling super.handleMessage(message).