Bug 140303 - [content assist] Move preference checks from AbstractJavaCompletionProposal to the completion context
Summary: [content assist] Move preference checks from AbstractJavaCompletionProposal t...
Status: RESOLVED WONTFIX
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.2   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2006-05-05 03:31 EDT by Tom Hofmann CLA
Modified: 2018-12-27 10:01 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Hofmann CLA 2006-05-05 03:31:18 EDT
Currently, AbstractJavaCompletionProposal and its subclasses check content assist preferences on their own, going through the preference store mechanism every time. This is not a problem for checks only done upon application, but should be avoided for checks that are invoked repeatedly or for every proposal (for example when validating).

These checks should best be moved to the content assist invocation context and cached there, as the preferences are not expected to change during one content assist invocation.

Post 3.2
Comment 1 Sebastian Oerding CLA 2010-02-02 03:29:24 EST
Hello,

I'm using Eclipse on an Ubuntu 8.04LTS on an Acer TravelMate 5320, dul core celeron, 3GB of RAM

I use the Eclipse SDK and the Eclipse JEE distribution, both 3.5 SR1,

when starting first the JEE and then (after shutdown of the JEE) the SDK version,
both working on the same workspace

when trying to do a code completion (in JavaDoc) a message pops up about the 
Advanced Content Assist preference page to open. When I open the suggested page, even clicking on Cancel making the code completion to work or just close the message.

Well, it's not such a problem, but annoying. It seems to be related with this issue, so Idon't report a new bug.

Sebastian
Comment 2 Dani Megert CLA 2010-02-02 03:33:55 EST
Sebastian, this is completely unrelated. The message probably informs you about either an error happening during content assist and hence asking to disable the bad processor in the preferences or it says the completion processor was too slow. If the dialog appears often then please file a new bug against JDT Text with exact steps to reproduce the problem.
Comment 3 Eclipse Genie CLA 2018-12-26 15:58:55 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 4 Dani Megert CLA 2018-12-27 10:01:10 EST
Currently no plans to work on this.