Bug 140123 - Missing callback in CodeSnippetToCuMapper#getCompletionRequestor()
Summary: Missing callback in CodeSnippetToCuMapper#getCompletionRequestor()
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M2   Edit
Assignee: David Audel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-04 04:52 EDT by David Audel CLA
Modified: 2006-09-18 10:57 EDT (History)
3 users (show)

See Also:

Attachments
Proposed fix (7.14 KB, patch)
2006-09-04 10:21 EDT, David Audel CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Audel CLA 2006-05-04 04:52:08 EDT 
From bug 139937

The completion requestor wrapper inside CodeSnippetToCuMapper#getCompletionRequestor() should override beginReporting(), endReporting() and should keep original proposal filters (isIgnored()).
Comment 1 David Audel CLA 2006-05-04 04:53:08 EDT 
Deferred post 3.2.
Comment 2 David Audel CLA 2006-09-04 10:20:35 EDT 
Reopened for 3.3.
Comment 3 David Audel CLA 2006-09-04 10:21:09 EDT 
Created attachment 49342 [details]
Proposed fix
Comment 4 David Audel CLA 2006-09-04 10:26:57 EDT 
Released for 3.3 M2.

Tests added
   CompletionTests#testEvaluationContextCompletion2() -> testEvaluationContextCompletion4()
Comment 5 Frederic Fusier CLA 2006-09-18 10:57:33 EDT 
Verified for 3.3 M2 using build I20060918-0010