Bug 140079 - enhance org.eclipse.cdt.utils.WindowsRegistry
Summary: enhance org.eclipse.cdt.utils.WindowsRegistry
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1   Edit
Assignee: Doug Schaefer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-05-03 16:50 EDT by Ling Wang CLA
Modified: 2008-06-19 13:42 EDT (History)
1 user (show)

See Also:

Attachments
patch to WindowsRegistry (2.52 KB, patch)
2006-05-03 16:51 EDT, Ling Wang CLA 		no flags Details | Diff
Extends windows registry utility (2.76 KB, patch)
2006-05-05 14:05 EDT, Ken Ryall CLA 		bjorn.freeman-benson: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ling Wang CLA 2006-05-03 16:50:05 EDT 
I've added a method to get value name of a registry key
  getLocalMachineValueName().
Please see attached patch.

Also as to the first method created by Doug 
     getLocalMachineValue()
which is intended for getting value data, is it better we rename it to
     getLocalMachineValueData() 
?
Comment 1 Ling Wang CLA 2006-05-03 16:51:32 EDT 
Created attachment 40300 [details]
patch to WindowsRegistry
Comment 2 Doug Schaefer CLA 2006-05-03 17:02:01 EDT 
Thanks, I'll take a look.
Comment 3 Doug Schaefer CLA 2006-05-04 10:52:58 EDT 
Apply patch isn't very happy with your patch. Did you create this using the Create Patch menu item?
Comment 4 Ling Wang CLA 2006-05-05 00:09:16 EDT 
No. I used diff command in CVS. But I just tried with Eclipse "Create Patch.." command and the output is the same. The only thing special is I manually put the patchs for two files (winreg.c and WindowsRegistry.java) in the same patch file.  Is that a problem ? Thanks.
Comment 5 Doug Schaefer CLA 2006-05-05 09:15:57 EDT 
Eclipse can handle patches from more than one plugin and it does so in it's own format so I'd be surprised if you got the same result as a cvs diff. Please attach the patch you created with Create Patch. Thanks.
Comment 6 Ken Ryall CLA 2006-05-05 14:05:50 EDT 
Created attachment 40506 [details]
Extends windows registry utility

This patch includes Ling's changes.
Comment 7 Doug Schaefer CLA 2006-05-11 11:12:36 EDT 
Applied the patch, thanks. I've left the getLocationMachineValue since it is a bit different. It uses Query instead of Enum. We can revisit this in CDT 4.0 and come up with a complete set that we'd like to have.