Bug 13995 - AST: DCR: BodyDeclaration.getModifiers
Summary: AST: DCR: BodyDeclaration.getModifiers
Status: RESOLVED WONTFIX
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.0 M6   Edit
Assignee: Jim des Rivieres CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-04-17 09:29 EDT by Martin Aeschlimann CLA
Modified: 2002-04-23 08:49 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2002-04-17 09:29:47 EDT 
20020416
Minor
All of its subtypes has get/setModifier.
It would be possible to have it in BodyDeclaration
Comment 1 Jim des Rivieres CLA 2002-04-17 10:26:22 EDT 
Each kind of BodyDeclaration has a different set of modifiers that are
legal for that type. So even if there was BodyDeclaration.get/setModifiers,
we might still want to retain separate spec refinements in each subclass.

More fundamentally, it feels like the fact that all BodyDeclarations
have modifiers is incidental, rather than something inherent. Would
anyone really care if a new kind of BodyDeclaration was added to the
language that happens to not have modifiers? I'd bet that anyone going
for modifiers also already knows the kind of node they are dealing with.

So while it would be possible to make this factoring, I can't see anyone 
benefitting from this minor change.
Comment 2 John Arthorne CLA 2002-04-19 18:12:51 EDT 
*** Bug 14267 has been marked as a duplicate of this bug. ***