Bug 139905 - [junit] No tests found must not be logged
Summary: [junit] No tests found must not be logged
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC All
: P3 minor (vote)
Target Milestone: 3.2 RC3   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2006-05-03 05:59 EDT by Tobias Widmer CLA
Modified: 2008-03-05 10:25 EST (History)
2 users (show)

See Also:

Attachments
Fix (6.00 KB, patch)
2006-05-04 12:33 EDT, Dani Megert CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Widmer CLA 2006-05-03 05:59:31 EDT 
3.2 RC2

Steps to reproduce:
- Comment all tests in junit.tests.AllTests#suite()
- Select package junit.tests
- Run as junit test

-> No tests found is logged
-> Dialog should have caption "JUnit", a better message such as "No testcases have been found in 'junit.tests'" and no details button.
Comment 1 Dani Megert CLA 2006-05-03 15:05:23 EDT 
Will investigate a fix and suggest to fix if the fix is trivial.
Comment 2 Dani Megert CLA 2006-05-04 12:33:09 EDT 
Created attachment 40372 [details]
Fix

I've already reviewed the fix with Tobias:

NOTE: The patch also adds missing '.' do the messages.
Comment 3 Dani Megert CLA 2006-05-04 12:33:45 EDT 
Approving for 3.2 RC3.

Markus, please cast your vote.
Comment 4 Markus Keller CLA 2006-05-04 12:35:22 EDT 
+1 for 3.2 RC3.
Comment 5 Dani Megert CLA 2006-05-04 12:36:29 EDT 
Fixed in HEAD.
Comment 6 Johannes Rieken CLA 2006-05-11 06:08:44 EDT 
verifying for 20060511-0010
Comment 7 Johannes Rieken CLA 2006-05-11 06:17:19 EDT 
verified that log stays clean and that dialog has a nice caption. 
Except for the '.', dialog message has been unchanged (improvement: add container name to message).
Comment 8 Neale Upstone CLA 2008-03-05 10:25:32 EST 
This is one of only two bugs that match a search for "no tests found".

In my view, there is a significant UI issue that was missed when this bug was reported.

I've raised this as bug 221525