Bug 139694 - [junit] Edit JUnit library dialog issues
Summary: [junit] Edit JUnit library dialog issues
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.2 RC3   Edit
Assignee: Tom Hofmann CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2006-05-02 10:29 EDT by Tobias Widmer CLA
Modified: 2006-05-10 04:26 EDT (History)
3 users (show)

See Also:

Attachments
139694.diff (2.72 KB, patch)
2006-05-04 09:09 EDT, Tom Hofmann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Widmer CLA 2006-05-02 10:29:47 EDT 
I20060428-1315

Steps to reproduce:
- Create a new project
- Create a JUnit4 testcase in it, using the wizard
- Verify that JUnit 4 container is visible under the project
- Select JUnit 4, select Configure...

-> Font of the current location field is not dialog font, but system font
-> The dialog misses the Library wizard banner image
-> The description should not talk about containers and how they resolve,
but rather something like "Select the JUnit version to use in this project"
Comment 1 Dani Megert CLA 2006-05-03 15:47:17 EDT 
New JUnit4 support polish.

Tom, please have a look at this.
Comment 2 Tom Hofmann CLA 2006-05-04 09:09:09 EDT 
Created attachment 40349 [details]
139694.diff

Patch against org.eclipse.jdt.junit. 

- corrects the descrition as required
- uses the library wizban from jdt-ui
- applies the parent (dialog) font to the library location

Patch reviewed by Benno.
Comment 3 Tom Hofmann CLA 2006-05-04 09:11:12 EDT 
Markus and Dani, please (dis)approve.
Comment 4 Markus Keller CLA 2006-05-04 09:25:08 EDT 
+1 for 3.2 RC3.
Comment 5 Dani Megert CLA 2006-05-04 12:02:55 EDT 
Approving for 3.2 RC3.
There's a minor issue left: the JAR path is not re-wrapped when the dialog is resized.

Fix if trival otherwise release the patch as is and file a new bug report.
Comment 6 Tom Hofmann CLA 2006-05-04 12:08:57 EDT 
Fixed > 20060504,

made the path resize and top-aligned the path label. Reviewed by Daniel Megert.
Comment 7 Johannes Rieken CLA 2006-05-10 04:10:11 EDT 
verifying for RC3
Comment 8 Johannes Rieken CLA 2006-05-10 04:17:09 EDT 
verified:
 - JAR path wraps nicely
 - font is ok, banner images is shown, description is good
Comment 9 Dani Megert CLA 2006-05-10 04:26:29 EDT 
.