Bug 13957 - LaunchingPlugin specification of resourceCopyExclusionFilter
Summary: LaunchingPlugin specification of resourceCopyExclusionFilter
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.0   Edit
Hardware: Other other
: P1 normal (vote)
Target Milestone: 2.0 M6   Edit
Assignee: Philipe Mulet CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-04-16 19:43 EDT by Darin Swanson CLA
Modified: 2002-05-03 11:23 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Swanson CLA 2002-04-16 19:43:03 EDT 
Currently there are bugs in the code.  The constant has changed and we should 
check for null when getting the key (even though JavaCore initializes the value 
to "").

More difficult:
The UI for manipulating the setting of this option in the JavaOptions does not 
take into consideration anyone setting a filter via code 
(JavaBuilderPreferencePage).  Is this an intended limitation?
Comment 1 Darin Swanson CLA 2002-04-16 19:44:12 EDT 
Can you comment Martin?
Comment 2 Martin Aeschlimann CLA 2002-04-17 03:02:25 EDT 
This is tricky. It's jdt.ui that is responsible for persisting the settings.
It also offers a preference page with a 'default' button, changing back all 
settings received by 'JavaCore.getDefaultOptions()'.

It seems to me that if other components also want to manipulate the setting, 
and don't want to know about jdt.ui (and the time it is loaded), persistence 
must go to jdt.core.

Or jdt.ui keeps the resposibility and have to offer API.
Comment 3 Darin Swanson CLA 2002-04-17 09:16:12 EDT 
Is there a possibility of JDT core using the new plugin preferences mechanism 
and jdt ui just putting a UI mechanism for manipulating the preference?
Comment 4 Martin Aeschlimann CLA 2002-04-17 09:24:48 EDT 
oh, you are right, that's now possible.
We should do it like that. Philippe?
Comment 5 Philipe Mulet CLA 2002-04-23 08:53:46 EDT 
Agreed.
Comment 6 Philipe Mulet CLA 2002-05-02 13:49:36 EDT 
Done, JavaCore options are now persisted through its plugin preferences.
Fixed
Comment 7 Martin Aeschlimann CLA 2002-05-03 11:23:11 EDT 
Changed Compiler/Builder & CodeFormatter Prefpage to not persisting settings 
anymore.
>20020502