Bug 139569 - Batch compiler should check if java home is null when trying to set the extDirs and endorsed dirs
Summary: Batch compiler should check if java home is null when trying to set the extDi...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 RC3   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-01 14:29 EDT by Olivier Thomann CLA
Modified: 2006-05-03 11:37 EDT (History)
2 users (show)

See Also:

Attachments
Proposed fix (1.60 KB, patch)
2006-05-01 14:37 EDT, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2006-05-01 14:29:12 EDT 
In RC2, when the java home is null and no extDirs or endorsed dirs are set, the batch compiler doesn't work.
It fails with a NPE.
Comment 1 Olivier Thomann CLA 2006-05-01 14:37:10 EDT 
Created attachment 39972 [details]
Proposed fix

The patch is trivial. It simply adds null checks when using javaHome for settings extdirs and endorsed dirs.
Candidate for RC3?
Comment 2 Philipe Mulet CLA 2006-05-01 16:11:13 EDT 
+1 for 3.2RC3
Comment 3 Philipe Mulet CLA 2006-05-01 16:17:18 EDT 
Dani - would you pls cast your vote ? Trivial fix for batch compiler.
Comment 4 Dani Megert CLA 2006-05-02 09:44:07 EDT 
Approving for 3.2 RC3.
Comment 5 Olivier Thomann CLA 2006-05-02 09:46:00 EDT 
Fixed and released in HEAD.
Comment 6 Dani Megert CLA 2006-05-02 09:50:33 EDT 
*** Please note: you first have to post the intended bug(s) to the releng list so that others can veto it, see:
http://www.eclipse.org/eclipse/development/freeze_plan_3.2.html
Comment 7 Olivier Thomann CLA 2006-05-02 09:55:46 EDT 
My understanding was to send the list of bugs fixed. But I didn't understand that the bug list had to be submitted prior to releasing them. It is a notification, not a vote. Did I miss anything?
Comment 8 Dani Megert CLA 2006-05-02 10:01:03 EDT 
It says: "Announce bug numbers of ***intended*** ...

My understanding in the >RC2 phase is that any component lead can veto any change at this time. Though that rarely happens.
Comment 9 Olivier Thomann CLA 2006-05-03 11:37:09 EDT 
Verified using N20060503-0010 for 3.2RC3 by creating the executable of the batch compiler using gcj. When running this executable, the java.home property is not set.