Bug 139140 - [JUnit] Compare Result dialog should not be modal
Summary: [JUnit] Compare Result dialog should not be modal
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M4   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
: 71102 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-04-28 09:38 EDT by Aaron Digulla CLA
Modified: 2006-11-14 12:35 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Digulla CLA 2006-04-28 09:38:39 EDT
Currently, the compare results dialog (in the Failure Trace view) is modal which means that I can't copy&paste several typos from it back into the source code.
Comment 1 Markus Keller CLA 2006-04-28 11:03:31 EDT
Nice suggestion.

We would have to make sure that the dialog is updated when another test is selected, and that it doesn't behave bad when the JUnit View loses focus or gets closed.
Comment 2 Aaron Digulla CLA 2006-04-29 11:10:40 EDT
How about converting it into a view? Users are used to the fact that the view doesn't change when it's not linked and (s)he selects some new element.

That would also solve the anoying overlap problem (the dialog overlaps some arbitrary part of the Eclipse window).
Comment 3 Markus Keller CLA 2006-05-01 13:55:18 EDT
A speparate "JUnit Failure Compare" view would be overkill. The dialog was chosen because presenting the compare editor inside the JUnit view would require most users to resize the view in order to see something useful.

An ordinary compare editor (opens in the editor area like the History view's compare editors) would probably be a more "eclipsish" UI.
Comment 4 Aaron Digulla CLA 2006-05-01 16:52:56 EDT
I would like to have this view where the Console is: This way, I can switch editors above and keep the compare view visible all the time.

Ok, I could split the editor area but I would have to do this all the time, so I would prefer this view to stick to the part below the editor area.
Comment 5 Markus Keller CLA 2006-11-14 12:34:42 EST
*** Bug 71102 has been marked as a duplicate of this bug. ***
Comment 6 Markus Keller CLA 2006-11-14 12:35:33 EST
Made the dialog non-modal for next week's integration build.