Community
Participate
Working Groups
Actually: If gmfgraph figure contains Label as a not direct child (say, when Ellipse contains Rectangle that in turn contains Label) and this label is set as a figure for appropriate LabelMapping, generated code can not be compiled (due to the absence of the getFigure<labelName> method in the generated figure code.) See attached test that currently fails demonstrating the problem. Expected: Figure generator should create getters for all figures that may be referenced by some other nodes. Attached tests hould not fail and diagram code should be generated without compilation errors.
Created attachment 39759 [details] Failing test LabelSupportTest#testDeepLabelGraphdefOnly() now fails demostrating the issue
Created attachment 39763 [details] Fixes the subj This patch includes tests for the issue described in the problem definition. IMPORTANT NOTE: Would be applied, this patch breaks the backward compatibility with all of alder gmfgraph model resources (because of added back reference Figure: ref DiagramElement[*]#figure referencingElements). Probably we need to provide tool that fixes old user files? As a minimum, this patch requires recreation of the gmf samples models (taipan, mindmap etc).
reviewed and committed
Created attachment 40174 [details] Corrected old gmfgraph resources broken by this patch
Created attachment 40260 [details] Additional test that demonstrates related problem with figures back-referencing diagram elements with spaced names
Created attachment 40261 [details] Additional test that demonstrates related problem with figures back-referencing diagram elements with spaced names Correct version, does not use file system for IO
[GMF Restructure] Bug 319140 : product GMF and component Generation was the original product and component for this bug
