Bug 139128 - Preserve visualID of the .gmfgen model nodes on modifying .gmfmap model.
Summary: Preserve visualID of the .gmfgen model nodes on modifying .gmfmap model.
Status: RESOLVED FIXED
Alias: None
Product: GMF-Tooling (ARCHIVED)
Classification: Modeling
Component: Core (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.0   Edit
Assignee: Alex Shatalin CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2006-04-28 09:15 EDT by Dmitry Stadnik CLA
Modified: 2010-07-19 12:19 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Stadnik CLA 2006-04-28 09:15:24 EDT
- Define diagram editor (gmf models)
- Generate diagram editor plugin
- Add a new label to some intermediate node
- Regenerate diagram editor plugin
=> visual ids of other labels (below the new one in sample ecore editor) are 
incremented so respective class names are changed (they contain visual id); as 
a result there are many changes that are not semantically related to the 
addition of the new label
Comment 1 Alex Shatalin CLA 2006-05-02 11:53:12 EDT
This is not a problem of labels - this is a generic problem of transformation from .gmfmap to .gmfgen model. 

To allow future changes of existing .gmfmap models and safe code regeneration GMF should take into account existing .gmfgen model while transforming .gmfmap to .gmfgen (preserve existing visualIDs of the .gmfgen model element). I.e. GMF should support the following usecases:

- new mapping was added to .gmfmap model and transformation from .gmfmap to .gmfgen executed -> new nodes should be added to existing .gmfgen models, but all the rest of the structure should not be changed (visualIDs of existing elements should not change the value).

- some mapping(s) was removed from .gmfmap model and transformation from .gmfmap to .gmfgen executed -> obsolete nodes should be removed from .gmfgen model, but visualIDs of an existing .gmfgen model elements should not be changed.

In other words, GMF should support "merging" of the changes from .gmfmap model to .gmfgen without modification of visualIDs. 

One of the reasons was clearly described in an original description another is – GMF should be able to open diagram file created using previous version of the generated diagramming plugin (visualIDs are currently stored in diagram file).
Comment 2 Alex Shatalin CLA 2006-05-24 14:09:51 EDT
oeg.bridge.trace plugin created. Additional .trace file will be created while transforming .gmfmap to .gmfgen model. This file will store visual id and OCL queries which will be used to assign correct visual id to genmodel elements on next genmodel regeneration. User could modify default ocl queries to tune trace file for specific changes in mappinf model.
Comment 3 Richard Gronback CLA 2008-08-13 13:05:24 EDT
[target cleanup] 1.0 RC4 was the original target milestone for this bug
Comment 4 Eclipse Webmaster CLA 2010-07-19 12:19:07 EDT
[GMF Restructure] Bug 319140 : product GMF and component
Templates was the original product and component for this bug