Bug 138903 - Template for the perspectives extension point
Summary: Template for the perspectives extension point
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M2   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
: 78481 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-04-27 09:33 EDT by Shaun Skelton CLA
Modified: 2007-06-05 18:04 EDT (History)
2 users (show)

See Also:

Attachments
Icon associated with patch (275 bytes, application/zip)
2006-04-27 09:34 EDT, Shaun Skelton CLA 		no flags Details
Perspective Template (20.60 KB, patch)
2006-04-27 09:39 EDT, Shaun Skelton CLA 		no flags Details | Diff
org.eclipse.pde.ui.patch (20.86 KB, patch)
2006-08-13 23:47 EDT, Chris Aniszczyk CLA 		no flags Details | Diff
org.eclipse.pde.ui.patch (1.31 KB, patch)
2006-08-14 23:43 EDT, Chris Aniszczyk CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shaun Skelton CLA 2006-04-27 09:33:03 EDT 
I have created a new template for the perspectives extension point however I have certain concerns.

I themed the sample perspective around Release Engineering and to accomplish this I have hardcoded some view id's into the sample code. While I normally would abstain from using hardcoded values, in this case it allowed for a bit more depth in the template. The two options I see are:

1) Keep the hardcoded values and theme to provide a template that's more interesting

2) Remove the hardcoded values, stick to using view id's that have public constants available, and adjust the template decription accordingly.
Comment 1 Shaun Skelton CLA 2006-04-27 09:34:32 EDT 
Created attachment 39659 [details]
Icon associated with patch

Path: /org.eclipse.pde.ui/templates_3.0/perspective/bin/icons/releng_gears.gif
Comment 2 Shaun Skelton CLA 2006-04-27 09:39:30 EDT 
Created attachment 39660 [details]
Perspective Template
Comment 3 Wassim Melhem CLA 2006-04-27 21:01:17 EDT 
*** Bug 78481 has been marked as a duplicate of this bug. ***
Comment 4 Chris Aniszczyk CLA 2006-08-10 14:49:21 EDT 
I'll look at cleaning this one up
Comment 5 Chris Aniszczyk CLA 2006-08-13 23:47:14 EDT 
Created attachment 47826 [details]
org.eclipse.pde.ui.patch

Updated patch against latest code base.
Comment 6 Chris Aniszczyk CLA 2006-08-13 23:48:25 EDT 
Hey Wassim, I updated the patch, however, I noticed a strange problem with our wizards. Sometimes when you go to the template and you're presented options, the wizard expands to the width of your screen. Let me know if you can reproduce that (open another bug?).

Other than that, the template looks good to go.
Comment 7 Wassim Melhem CLA 2006-08-13 23:54:42 EDT 
Chris, I told you about the wizard being too wide issue in bug 145854 comment 5.

I opened a bug report (bug 153536) against Platform/UI regarding the issue.
Comment 8 Chris Aniszczyk CLA 2006-08-14 00:07:05 EDT 
note to self, Wassim has a good memory
Comment 9 Wassim Melhem CLA 2006-08-14 00:50:05 EDT 
Released the patch.

Chris, the binary icon in the patch messed it up.

Also the patch is missing mnemonics for the checkboxes on the template page.  please provide a fixpack :)
Comment 10 Chris Aniszczyk CLA 2006-08-14 23:43:58 EDT 
Created attachment 47889 [details]
org.eclipse.pde.ui.patch

there you go
Comment 11 Wassim Melhem CLA 2006-08-14 23:48:19 EDT 
Thanks Shaun and Chris.