Bug 138516 - DiagramEventBrokerCommand should implement canRedo() using the EMF-TX extension to the Command interface
Summary: DiagramEventBrokerCommand should implement canRedo() using the EMF-TX extensi...
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0   Edit
Hardware: PC Linux
: P2 major
Target Milestone: 1.0   Edit
Assignee: Christian Damus CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on: 138287
Blocks:
  Show dependency tree
 
Reported: 2006-04-25 17:08 EDT by Christian Damus CLA
Modified: 2010-07-19 12:24 EDT (History)
1 user (show)

See Also:

Attachments
Patch to implement the required method (2.00 KB, patch)
2006-05-02 10:01 EDT, Christian Damus CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Damus CLA 2006-04-25 17:08:34 EDT 
The DiagramEventBrokerCommand class defined by the DiagramEditingDomain should implement the ConditionallyRedoableCommand interface to provide the canRedo() method, when bug 138287 is resolved and the next EMFT build is adopted by GMF.

This will be required for ICommands and IUndoableOperations executed by the diagram event broker to include their redoability in the computation of the overall redoability of the operation/transaction that the event broker extends.

This defect is targeted to the Runtime EMF Core team because they (I) implemented the DiagramEventBrokerCommand for inserting the broker's changes via the TriggerCommand.
Comment 1 Christian Damus CLA 2006-05-02 10:01:23 EDT 
Created attachment 40038 [details]
Patch to implement the required method

Attached a patch that updates the DiagramEventBrokerCommand to implement the new ConditionalRedoCommand interface.
Comment 2 Christian Damus CLA 2006-05-02 10:02:12 EDT 
Adding Vishy to the cc: to review and (hopefully) apply the patch.
Comment 3 Vishy Ramaswamy CLA 2006-05-02 11:10:49 EDT 
Reviewed and applied patch
Comment 4 Richard Gronback CLA 2008-08-13 13:04:19 EDT 
[target cleanup] 1.0 RC was the original target milestone for this bug
Comment 5 Eclipse Webmaster CLA 2010-07-19 12:24:18 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime EMF was the original product and component for this bug