Bug 138432 - Spec of ICodeAssist#codeSelect() doesn't describe the behavior of empty selection
Summary: Spec of ICodeAssist#codeSelect() doesn't describe the behavior of empty selec...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 RC2   Edit
Assignee: David Audel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-25 13:02 EDT by David Audel CLA
Modified: 2006-04-28 14:21 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Audel CLA 2006-04-25 13:02:40 EDT 
From bug 94705.

The spec of ICodeAssist#codeSelect() doesn't descibe that we return the element just before the offset when the length is 0.

1) create X.java
class X implemnents Runnable| {
}
2) Do F3 at | location.
Comment 1 David Audel CLA 2006-04-25 13:29:54 EDT 
I suggest to add the following lines to the spec of ICodeAssist#codeSelect(...)

* <p>
* Note that if the <code>length</code> is 0 and the <code>offset</code> is inside an identifier 
* or the index just after an identifier then this identifier is considered as the selection.
* </p>
Comment 2 Philipe Mulet CLA 2006-04-26 05:24:26 EDT 
+1 for 3.2RC2
Comment 3 David Audel CLA 2006-04-26 06:03:53 EDT 
Javadoc update released.
Comment 4 Olivier Thomann CLA 2006-04-28 14:21:36 EDT 
Verified with I20060427-1600 for 3.2RC2