Bug 138345 - [polish] Move "Add" items into submenu
Summary: [polish] Move "Add" items into submenu
Status: CLOSED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.xsd (show other bugs)
Version: 1.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M2   Edit
Assignee: Gabriel Indik CLA
QA Contact:
URL:
Whiteboard: reviewed_1.5
Keywords: contributed
: 153981 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-04-25 08:53 EDT by Gunnar Wagenknecht CLA
Modified: 2008-04-24 17:40 EDT (History)
4 users (show)

See Also:


Attachments
Screenshot of alternatives (133.29 KB, image/jpeg)
2007-02-14 12:59 EST, Gabriel Indik CLA
no flags Details
Patch: Non-cascading version (8.57 KB, patch)
2007-02-14 13:01 EST, Gabriel Indik CLA
bjorn.freeman-benson: iplog+
Details | Diff
Patch: Cascading version (24.20 KB, patch)
2007-02-14 13:07 EST, Gabriel Indik CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gunnar Wagenknecht CLA 2006-04-25 08:53:17 EDT
1.5 RC1a 

Instead of many, many "Add XYZ" items there should be one "New >" menu with all items as sub menu. Similar to the "New" menu in the context menu of the Navigator.

It would be also better to provide more descriptive names. For example, instead of "Add Element Ref" it would be better to write "New -> Element Reference".
Comment 1 Keith Chong CLA 2006-06-06 18:53:06 EDT
Reviewed for WTP 1.5.   I agree, this could be organized better with a cascade menu.
Comment 2 Craig Salter CLA 2006-09-06 01:34:36 EDT
Gabriel, I believe you have a patch for this.
Comment 3 Gabriel Indik CLA 2007-02-14 12:32:43 EST
*** Bug 153981 has been marked as a duplicate of this bug. ***
Comment 4 Gabriel Indik CLA 2007-02-14 12:59:49 EST
Created attachment 58983 [details]
Screenshot of alternatives

In addition to the use of cascading menu items, icons and separators were also incorporated in order to further enhance the look and feel of the context menu.
There is however a trade-off in this design given that the user will now have to navigate through the cascading menu in search for those items that were previously available with just one click.
For this reason two patches were developed, both incorporate the icons and additional separators, but only one uses cascading menus.
Comment 5 Gabriel Indik CLA 2007-02-14 13:01:54 EST
Created attachment 58984 [details]
Patch: Non-cascading version
Comment 6 Gabriel Indik CLA 2007-02-14 13:07:09 EST
Created attachment 58988 [details]
Patch: Cascading version

Cascading submenu are shown to the user only when there are two or more "add" items, otherwise the only "add" item to be shown appears on the top-level of the context menu.
Comment 7 Keith Chong CLA 2007-09-12 15:21:39 EDT
Non-cascading version checked in for WTP 3.0.
Comment 8 Nitin Dahyabhai CLA 2007-09-13 14:53:28 EDT
Moving out to 3.0 in general.  Please upate the target value when you commit the fix.
Comment 9 Gabriel Indik CLA 2008-04-07 15:15:02 EDT
Non-cascading version verified
Comment 10 Valentin Baciu CLA 2008-04-08 16:43:51 EDT
Closing.
Comment 11 David Williams CLA 2008-04-24 00:43:56 EDT
mass change to add 'contributed' keyword based on bugzilla query, please correct if that's not accurate (by marking patches as obsolete and removing the 'contributed' keyword. 
Comment 12 Valentin Baciu CLA 2008-04-24 17:40:31 EDT
Comment on attachment 58988 [details]
Patch: Cascading version

This patch was not committed as it was decided to use the non-cascading version.