Bug 137840 - [gmfgen/gmfgraph]: uncompiliable code if CustomFigure contains Label
Summary: [gmfgen/gmfgraph]: uncompiliable code if CustomFigure contains Label
Status: RESOLVED FIXED
Alias: None
Product: GMF-Tooling (ARCHIVED)
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Michael Golubev CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-04-20 16:59 EDT by Michael Golubev CLA
Modified: 2010-07-19 22:18 EDT (History)
0 users

See Also:

Attachments
Failing test case. (2.78 KB, text/plain)
2006-04-20 17:01 EDT, Michael Golubev CLA 		no flags Details
Fixes the subj (309.96 KB, patch)
2006-04-20 18:58 EDT, Michael Golubev CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Golubev CLA 2006-04-20 16:59:07 EDT 
Attached test should not fail.
This bug is inspired by news://news.eclipse.org/op.s79hwbl5e4f77a@merkur post.
Comment 1 Michael Golubev CLA 2006-04-20 17:01:04 EDT 
Created attachment 39109 [details]
Failing test case. 

For the same configuration (figure + label) it does not fail if figure is gmf.Rectangle, but fails if it is the custom figure.
Comment 2 Michael Golubev CLA 2006-04-20 18:58:57 EDT 
Created attachment 39122 [details]
Fixes the subj

Patch introduces the new FigureBase abstract class into gmfgraph.
This classifier conatins the only resolvedChildren derived feature moved to here from gmfgraph.Shape.
CustomFigure and LabeledContainer now extends FigureBase
Custom connections/decorations as well as labels do not extends this interface, because their children has no much sense.

for top-level templates the one previously registered for Shape is re-registered for FigureBase that allows to generate child accessors for all FigureBase's.
Comment 3 Artem Tikhomirov CLA 2006-04-21 14:01:36 EDT 
Comment on attachment 39122 [details]
Fixes the subj

It's much easier to fix the issue with removing Figure.javajet which is merely a "just-do-it-different-way" incarnation of Shape.javajet
Comment 4 Artem Tikhomirov CLA 2006-04-21 14:02:31 EDT 
TestCase committed. Fixed with replacing top/Figure.javajet with content of top/Shape.javajet
Comment 5 Eclipse Webmaster CLA 2010-07-19 22:18:35 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Generation was the original product and component for this bug