Bug 137456 - NPE when trying to view a class file with attached source
Summary: NPE when trying to view a class file with attached source
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.2 RC2   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-19 03:56 EDT by Ian Meikle CLA
Modified: 2006-04-28 14:36 EDT (History)
1 user (show)

See Also:


Attachments
Proposed patch and regression test (2.21 KB, patch)
2006-04-19 11:27 EDT, Jerome Lanneluc CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Meikle CLA 2006-04-19 03:56:41 EDT
In both 3.2M6 + RC1.
When trying to view a class file from a jar file with attached source I get the follwoing:

!ENTRY org.eclipse.jface 4 2 2006-04-19 08:39:17.022
!MESSAGE Problems occurred when invoking code from plug-in: "org.eclipse.jface".
!STACK 0
java.lang.NullPointerException
	at org.eclipse.jdt.ui.JavaElementLabels.getCategoryLabel(JavaElementLabels.java:640)
	at org.eclipse.jdt.ui.JavaElementLabels.getTypeLabel(JavaElementLabels.java:908)
	at org.eclipse.jdt.ui.JavaElementLabels.getElementLabel(JavaElementLabels.java:430)
	at org.eclipse.jdt.ui.JavaElementLabels.getElementLabel(JavaElementLabels.java:395)
	at org.eclipse.jdt.ui.JavaElementLabels.getTextLabel(JavaElementLabels.java:377)
	at org.eclipse.jdt.internal.ui.viewsupport.JavaUILabelProvider.getText(JavaUILabelProvider.java:161)
	at org.eclipse.jface.viewers.DecoratingLabelProvider.getText(DecoratingLabelProvider.java:129)
	at org.eclipse.jface.viewers.DecoratingLabelProvider.updateLabel(DecoratingLabelProvider.java:229)
	at org.eclipse.jface.viewers.StructuredViewer.buildLabel(StructuredViewer.java:1997)
	at org.eclipse.jface.viewers.TableViewer.doUpdateItem(TableViewer.java:468)
	at org.eclipse.jface.viewers.StructuredViewer$UpdateItemSafeRunnable.run(StructuredViewer.java:464)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:37)
	at org.eclipse.core.runtime.Platform.run(Platform.java:816)
	at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:44)
	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:149)
	at org.eclipse.jface.viewers.StructuredViewer.updateItem(StructuredViewer.java:1901)
	at org.eclipse.jface.viewers.TableViewer.createItem(TableViewer.java:350)
	at org.eclipse.jface.viewers.TableViewer.internalRefreshAll(TableViewer.java:923)
	at org.eclipse.jface.viewers.TableViewer.internalRefresh(TableViewer.java:818)
	at org.eclipse.jface.viewers.TableViewer.internalRefresh(TableViewer.java:807)
	at org.eclipse.jface.viewers.StructuredViewer$7.run(StructuredViewer.java:1359)
	at org.eclipse.jface.viewers.StructuredViewer.preservingSelection(StructuredViewer.java:1294)
	at org.eclipse.jface.viewers.StructuredViewer.refresh(StructuredViewer.java:1357)
	at org.eclipse.jface.viewers.StructuredViewer.refresh(StructuredViewer.java:1316)
	at org.eclipse.jface.viewers.TableViewer.inputChanged(TableViewer.java:767)
	at org.eclipse.jface.viewers.ContentViewer.setInput(ContentViewer.java:250)
	at org.eclipse.jface.viewers.StructuredViewer.setInput(StructuredViewer.java:1513)
	at org.eclipse.jdt.internal.ui.browsing.JavaBrowsingPart.setViewerInput(JavaBrowsingPart.java:793)
	at org.eclipse.jdt.internal.ui.browsing.JavaBrowsingPart.setInput(JavaBrowsingPart.java:779)
	at org.eclipse.jdt.internal.ui.browsing.JavaBrowsingPart.adjustInputAndSetSelection(JavaBrowsingPart.java:1011)
	at org.eclipse.jdt.internal.ui.browsing.JavaBrowsingPart.setSelectionFromEditor(JavaBrowsingPart.java:1177)
	at org.eclipse.jdt.internal.ui.browsing.JavaBrowsingPart.selectionChanged(JavaBrowsingPart.java:717)
	at org.eclipse.jdt.internal.ui.browsing.TypesView.selectionChanged(TypesView.java:201)
	at org.eclipse.ui.internal.AbstractSelectionService.firePostSelection(AbstractSelectionService.java:179)
	at org.eclipse.ui.internal.AbstractSelectionService.setActivePart(AbstractSelectionService.java:289)
	at org.eclipse.ui.internal.WorkbenchPagePartList.fireActivePartChanged(WorkbenchPagePartList.java:59)
	at org.eclipse.ui.internal.PartList.setActivePart(PartList.java:126)
	at org.eclipse.ui.internal.WorkbenchPage.setActivePart(WorkbenchPage.java:3105)
	at org.eclipse.ui.internal.WorkbenchPage.activate(WorkbenchPage.java:585)
	at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditorBatched(WorkbenchPage.java:2512)
	at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor(WorkbenchPage.java:2436)
	at org.eclipse.ui.internal.WorkbenchPage.access$10(WorkbenchPage.java:2428)
	at org.eclipse.ui.internal.WorkbenchPage$9.run(WorkbenchPage.java:2413)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:69)
	at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2408)
	at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2393)
	at org.eclipse.jdt.internal.ui.javaeditor.EditorUtility.openInEditor(EditorUtility.java:287)
	at org.eclipse.jdt.internal.ui.javaeditor.EditorUtility.openInEditor(EditorUtility.java:164)
	at org.eclipse.jdt.internal.ui.actions.OpenActionUtil.open(OpenActionUtil.java:49)
	at org.eclipse.jdt.ui.actions.OpenAction.run(OpenAction.java:181)
	at org.eclipse.jdt.ui.actions.OpenAction.run(OpenAction.java:144)
	at org.eclipse.jdt.ui.actions.SelectionDispatchAction.dispatchRun(SelectionDispatchAction.java:271)
	at org.eclipse.jdt.ui.actions.SelectionDispatchAction.run(SelectionDispatchAction.java:243)
	at org.eclipse.jdt.internal.ui.javaeditor.JavaElementHyperlink.open(JavaElementHyperlink.java:55)
	at org.eclipse.jface.text.hyperlink.HyperlinkManager.mouseUp(HyperlinkManager.java:383)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:137)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:925)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3346)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2966)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1914)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1878)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:419)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:143)
	at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:95)
	at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:78)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:92)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:68)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:376)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:169)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.eclipse.core.launcher.Main.invokeFramework(Main.java:336)
	at org.eclipse.core.launcher.Main.basicRun(Main.java:280)
	at org.eclipse.core.launcher.Main.run(Main.java:977)
	at org.eclipse.core.launcher.Main.main(Main.java:952)
Comment 1 Frederic Fusier CLA 2006-04-19 04:02:13 EDT
Move to JDT/UI
Comment 2 Martin Aeschlimann CLA 2006-04-19 09:51:02 EDT
Moving to jdt.core.

It seems member.getCategories() returns null, which is against the spec.
Comment 3 Philipe Mulet CLA 2006-04-19 10:01:34 EDT
+1 for 3.2RC2
Comment 4 Jerome Lanneluc CLA 2006-04-19 11:27:28 EDT
Created attachment 38930 [details]
Proposed patch and regression test
Comment 5 Jerome Lanneluc CLA 2006-04-19 11:40:15 EDT
Released patch and regression test
Comment 6 Olivier Thomann CLA 2006-04-28 14:36:48 EDT
Verified with I20060427-1600 for 3.2RC2 (checking the source code)