Bug 137339 - Edit JRE dialog buttons are not visible when vmargs is very long
Summary: Edit JRE dialog buttons are not visible when vmargs is very long
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.2 RC3   Edit
Assignee: Kevin Barnes CLA
QA Contact:
URL:
Whiteboard:
Keywords: greatbug
Depends on:
Blocks:
 
Reported: 2006-04-18 15:21 EDT by Jay Rosenthal CLA
Modified: 2006-05-05 16:14 EDT (History)
2 users (show)

See Also:

Attachments
Picture of dialog with button clipped from view (31.68 KB, image/gif)
2006-04-18 15:23 EDT, Jay Rosenthal CLA 		no flags Details
Patch to AddVmDialog prevents butons from being clipped if vmargs are really long (881 bytes, patch)
2006-04-20 16:31 EDT, Jay Rosenthal CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jay Rosenthal CLA 2006-04-18 15:21:17 EDT 
When configuring a JRE with very long vmargs, the buttons on the right side of the dialog are not visible and sometimes not acessible at all.  Depending on the length  of the vmargs, resizing the window may make the buttons appear.  The buttons I'm referring to are "Add External Jar", "Edit", "Remove" etc.

The vmargs in question look like :
-Djava.util.logging.config.class=com.ibm.rcp.core.logger.boot.LoggerConfig -cp c:/wct30/wct-rcp/lwp04.wct-rcp/lwp/build/rcp/eclipse/plugins/com.ibm.rcp.core.connect/connect.jar;c:/wct30/wct-rcp/lwp04.wct-rcp/lwp/build/rcp/eclipse/plugins/com.ibm.rcp.core.launcher/launcher.jar;c:/wct30/wct-rcp/lwp04.wct-rcp/lwp/build/rcp/eclipse/startup.jar
Comment 1 Jay Rosenthal CLA 2006-04-18 15:23:29 EDT 
Created attachment 38842 [details]
Picture of dialog with button clipped from view

Here' a picture of the dialog with the buttons clipped off of the dialog
Comment 2 Jay Rosenthal CLA 2006-04-20 16:31:43 EDT 
Created attachment 39102 [details]
Patch to AddVmDialog prevents butons from being clipped if vmargs are really long

This patch appears to be simple fix for the problem.  It ensures that the VMArgs text box has a widthHint set, so when the window size is computed the grid layout around the text box does not cause other controls to be clipped.

File:
ui/org/eclipse/jdt/internal/debug/ui/jres/AddVMDialog.java
Comment 3 Darin Wright CLA 2006-05-02 17:16:42 EDT 
Marking as RC3 candidate. Simple fix.

CC'ing Markus for approval.
Comment 4 Markus Keller CLA 2006-05-03 05:35:32 EDT 
+1 for 3.2 RC3.
Comment 5 Darin Wright CLA 2006-05-03 10:18:21 EDT 
This is a greatbug. It describes the problem, shows the problem with a screen shot, and provides a patch that fixes the problem.
Comment 6 Darin Wright CLA 2006-05-03 10:18:45 EDT 
Applied patch.
Comment 7 Darin Wright CLA 2006-05-03 10:19:01 EDT 
please verify, Kevin.
Comment 8 Kevin Barnes CLA 2006-05-05 16:14:55 EDT 
verified