Bug 137337 - Incremental compiler often results in incorrect weaving...
Summary: Incremental compiler often results in incorrect weaving...
Status: REOPENED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: DEVELOPMENT   Edit
Hardware: PC Windows XP
: P5 normal (vote)
Target Milestone: ---   Edit
Assignee: aspectj inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-18 15:19 EDT by Ramnivas Laddad CLA
Modified: 2009-08-30 02:50 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ramnivas Laddad CLA 2006-04-18 15:19:15 EDT
This is becoming a big problem on a current project. Quite often (more so after 
switching to 1.5.1+, it seems), a developer will call me with a problem that an 
aspect should have taken care of, but clearly isn't. After looking at code, it 
seems all fine. So in a dismay, I fire a clean compile and the problems goes away.

I wanted to see if there is a pattern here, but failed to observe any 
relationship between the kind of changes leading to the problem. The general 
characteristics only tell that the classes, and not the aspects are changed before
we observe this problem.
Comment 1 Ramnivas Laddad CLA 2006-04-18 17:57:36 EDT
The most common problem seen is an advice that stops being applied to a 
join point (method execution) after an incremental compilation, but works 
fine after a clean build.
Comment 2 Andrew Clement CLA 2006-04-19 04:44:06 EDT
I do know of a change vaguely in that area during the 1.5.1 timeframe.  Can you possibly turn on all the debug that you can for the AJDT event trace view?  When you make a change to a class file it should report some information about the decision process it is following - why certain things are being compiled and any knock-on effects of that.  Using your knowledge of what the change was, does the list of changes make sense?
Comment 3 Andrew Clement CLA 2006-05-04 15:08:05 EDT
Ramnivas - is this still happening for you? Did you get a chance to try creating the AJDT event trace that might indicate what is happening?  

And its *definetly* that the code on the disk is not woven, yes? Not just that the markers are missing?
Comment 4 Andrew Clement CLA 2006-05-04 15:23:51 EDT
marking up the severity so I can see it in the big list-o-bugs.
Comment 5 Ramnivas Laddad CLA 2006-05-04 19:03:44 EDT
It hasn't happended in a while (to make matter worse, it used to happen on other 
developer's machine, and I have less control over its environment). 
I am still keeping my eyes on this problem.

When it happened, however, the problem was advice not getting applied in byte 
code (and not just missing markers). Basically, the functionality implemented
with aspects was absent, leading to bizzare behavior (and often crash). On
every occasion, full rebuild solved the problem.
Comment 6 Andrew Clement CLA 2006-05-17 11:48:45 EDT
any sign of this bug recurring ???
Comment 7 Ramnivas Laddad CLA 2006-05-17 12:11:51 EDT
Nope. Also, the project has gone into functional QA testing so 
not much is being changed. That poses the problem of what to do with this bug. 
May be mark it as "later" and reduce is severity (due to non reoccurance)?
Comment 8 Andrew Clement CLA 2006-05-17 14:07:28 EDT
I'm ok with that - if you see anything like it again we can resurrect this bug.
Comment 9 Eclipse Webmaster CLA 2009-08-30 02:50:58 EDT
LATER/REMIND bugs are being automatically reopened as P5 because the LATER and REMIND resolutions are deprecated.