Bug 136629 - [performance] plugin converter should use ZipFile not JarFile
Summary: [performance] plugin converter should use ZipFile not JarFile
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Framework (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M1   Edit
Assignee: equinox.framework-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2006-04-13 09:52 EDT by Thomas Watson CLA
Modified: 2006-06-15 11:03 EDT (History)
2 users (show)

See Also:

Attachments
patch (1.91 KB, patch)
2006-06-15 11:01 EDT, Thomas Watson CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Watson CLA 2006-04-13 09:52:05 EDT 
Not that bundles are going to be signed using JarFile in the plugin converter will result in a performance hit.

There is no reason to use JarFile in this case.  We should look to using ZipFile for RC2.
Comment 1 Thomas Watson CLA 2006-04-17 15:24:55 EDT 
slipping to 3.3 ...

bug 136662 addressed the performance concerns.  Moving to ZipFile is not necessary for 3.2.
Comment 2 BJ Hargrave CLA 2006-04-17 15:46:39 EDT 
If you do use ZipFile, please make sure to properly order the manifest entry in the resulting jar file. See Bug 136810.
Comment 3 Thomas Watson CLA 2006-04-17 16:54:04 EDT 
This bug is about jar/zip file reading not creating so there is no issue about ordering of the manifest here.  

The converter just reads the content of the jar file (plugin.xml, manifest.mf etc) and creates a bundle manifest for the Framework to use in place of the original manifest supplied by the bundle.  It does not modify or create a jar file.
Comment 4 BJ Hargrave CLA 2006-04-17 17:08:53 EDT 
(In reply to comment #3)
Then, nevermind... :-)
Comment 5 Jeff McAffer CLA 2006-04-17 21:41:33 EDT 
Just want to clarify here.  If we are using JarFile and things are signed then we will get whacked no?  If bug 136662 fixed the problem, why is this one not closed?
Comment 6 Thomas Watson CLA 2006-04-18 08:53:26 EDT 
bug 136662 was a one line change to the create the JarFile with 
new JarFile(bundleFile, false) to indicate that the jar should not be varified.

This bug is to move completely off of using JarFile and instead use ZipFile because there is no real reason for us to be using JarFile in the converter.  A motivation for doing this would be to allow the plugin converter to run on OSGi/Minimum because JarFile does not exist there.  To me that is low priority since this is a compatibility thing anyway and it currently runs fine on Foundation.
Comment 7 Jeff McAffer CLA 2006-04-18 22:56:24 EDT 
thanks for the clarificaiton.  We could just do the change to zip fiels with no real risk right?
Comment 8 Thomas Watson CLA 2006-06-15 11:01:11 EDT 
Created attachment 44525 [details]
patch

The risk is low, but the benifit is pretty low also.  I will release this patch for 3.3.  I don't see a need for this in 3.2.1.
Comment 9 Thomas Watson CLA 2006-06-15 11:03:42 EDT 
Fixed for 3.3 M1.  Jeff you can reopen if you feel this should be fixed in 3.2.1.