Bug 135906 - CompilationUnitStructureRequestor.resolveDuplicates has bad performance
Summary: CompilationUnitStructureRequestor.resolveDuplicates has bad performance
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M1   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2006-04-10 11:51 EDT by Dani Megert CLA
Modified: 2008-12-12 04:02 EST (History)
2 users (show)

See Also:

Attachments
Proposed fix and performance test (4.72 KB, patch)
2008-06-10 09:11 EDT, Jerome Lanneluc CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2006-04-10 11:51:45 EDT 
N20060410-0010.

I know having many duplicates of the same member isn't a common case but if that happens the performance gets very bad.

Test Case:
1. create CU Foo.java
2. add method void foo() {}
3. make 4000 copies for it and save
4. close editor
5. open editor
==> takes very long

Now comment out the code in resolveDuplicates()
==> editor opens quite fast
Comment 1 Jerome Lanneluc CLA 2006-05-03 07:32:09 EDT 
Post 3.2
Comment 2 Dani Megert CLA 2006-06-16 08:46:08 EDT 
Can this now be reopened for 3.3.?
Comment 3 Jerome Lanneluc CLA 2006-06-16 08:49:39 EDT 
Reopening to consider in 3.3
Comment 4 Jerome Lanneluc CLA 2007-06-21 05:03:25 EDT 
We could have a separate table from original handle (i.e. with occurrenceCount == 0) to current occurrence count.
Comment 5 Jerome Lanneluc CLA 2008-05-07 07:59:19 EDT 
Deferring again (sorry Dani)
Comment 6 Jerome Lanneluc CLA 2008-06-10 09:11:11 EDT 
Created attachment 104305 [details]
Proposed fix and performance test
Comment 7 Jerome Lanneluc CLA 2008-06-26 07:16:55 EDT 
Fix and performance test released for 3.5M1 in HEAD.
Performance test released in perf_34x branch.
Comment 8 Olivier Thomann CLA 2008-08-08 10:57:32 EDT 
Will be verified once the performance test results are back.
Comment 9 Frederic Fusier CLA 2008-12-12 04:02:26 EST 
Verified for 3.5M4 using performance results of build I20081211-0100.