Bug 135838 - [search] Improve search progress monitor label
Summary: [search] Improve search progress monitor label
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 RC1   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-10 05:47 EDT by Martin Aeschlimann CLA
Modified: 2006-04-13 11:05 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2006-04-10 05:47:32 EDT 
20060410

The Java search progress monitor task is currently showing

Java: locate matches...

The prefix 'Java:' looks ugly and seems unnecessary. If it is necessary, better say something like 'Locating Java matches...'

In the text search we show:
'Scanning file 1 of 100: A.java'
Comment 1 Philipe Mulet CLA 2006-04-10 07:07:17 EDT 
This is the participant API which is at work here.
Need to be careful.
Comment 2 Frederic Fusier CLA 2006-04-10 09:58:04 EDT 
First, we do not update this label for each scanned file while indexing files or locating matches as it would have a big hit on performances.
Second, message is:
"{0}: locate matches..."
where parameter is the Search Participant description returned by API method IJavaSearchParticipant.getDescription()

So, I would say that best solution would be to change the entire message in messages.properties of o.e.jdt.internal.core.util package.

Your proposal looks good (e.g. "Locate {0} matches...") as this message is also used in combined phrase. For example in preview of Rename dialog, you can have:
"Searching for references... Locate {0} matches..."
and
"Checking preconditions... Locate {0} matches..."

Philippe, does it sound OK for you? If, so please accept this bug for RC1, thanks
Comment 3 Philipe Mulet CLA 2006-04-10 10:16:10 EDT 
Should be "Locating" not "Locate".
+1 for 3.2RC1 as minor polish.
Comment 4 Frederic Fusier CLA 2006-04-11 03:59:35 EDT 
I've modified properties as follows:
engine_searching_indexing = Looking through {0} indexes...
engine_searching_matching = Locating {0} matches...

Fixed and released in HEAD
Comment 5 Jerome Lanneluc CLA 2006-04-13 11:05:18 EDT 
Verified for 3.2 RC1 using build I20060413-0010