Bug 135583 - [navigation] Mark Occurrences of 'this'
Summary: [navigation] Mark Occurrences of 'this'
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.2   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-07 11:49 EDT by Tobias Widmer CLA
Modified: 2006-04-10 07:19 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Widmer CLA 2006-04-07 11:49:10 EDT
N20060407-0010

It would be nice to highlight occurrences of 'this' as well.
Comment 1 Dani Megert CLA 2006-04-08 08:46:00 EDT
Please provide more info, e.g. in the following code snippet:

...
this.foo();
foo();
th<caret>is.bar();
...

what would you highlight and what would be the benefit?
Comment 2 Tobias Widmer CLA 2006-04-10 06:57:54 EDT
Just highlight all identifiers of 'this' (ThisExpression). For qualified this expressions, highlight the 'this' expressions where the qualifier matches:

this.foo();
Outer.this.bar();
OuterOuter.<hilite>th<caret>is</hilite>.bar1();
OuterOuter.<hilite>this</hilite>.bar2();
this.foo1(OuterOuter.<hilite>this</hilite>)

Conceptionally, this is an expression like eg. field accesses and highlighting occurrences would bring the same benefit as for field accesses, such as quick usage overview as method arguments or qualifiers

Comment 3 Dani Megert CLA 2006-04-10 07:12:05 EDT
OK, so you wouldn't want/need to also highlight the second foo() from comment 1 somehow?
Comment 4 Tobias Widmer CLA 2006-04-10 07:17:51 EDT
No, just occurrences of the 'this' keyword, resolving to the same binding