Bug 135545 - The pathmaps preference page allows me to override path map variables contributed through the extension point
Summary: The pathmaps preference page allows me to override path map variables contrib...
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P2 major
Target Milestone: 1.0   Edit
Assignee: Christian Damus CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks: 143533
  Show dependency tree
 
Reported: 2006-04-07 10:21 EDT by Chris McGee CLA
Modified: 2010-07-19 12:24 EDT (History)
1 user (show)

See Also:

Attachments
Updates to the preference page (22.78 KB, patch)
2006-05-24 13:01 EDT, Christian Damus CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris McGee CLA 2006-04-07 10:21:24 EDT 
The modeling path maps variable dialog should not allow one to contribute a variable that conflicts with one contributed through the extension point.
Comment 1 Christian Damus CLA 2006-05-24 13:01:23 EDT 
Created attachment 42455 [details]
Updates to the preference page

Attached a patch that makes the following changes to the preference page:

  - show the system-defined modeling path variables at the bottom of the
    right-hand list
  - prevent moving variables from the left-hand to the right-hand list
    where the names collide (can only occur in collision with the system
    variables).  An appropriate message is shown
  - sort both lists (on the right-hand side, grouping the system-defined
    variables together after the user-defined variables)

Currently, it may look a little strange that the same variable name can appear in both lists:  on the left-hand side is the user's variable, on the right the system-defined variable.  These are actually two different variables, which would be clarified by resolution of bug 143533.
Comment 2 Vishy Ramaswamy CLA 2006-05-24 13:18:00 EDT 
Reviewed and applied patch
Comment 3 Richard Gronback CLA 2008-08-13 13:05:22 EDT 
[target cleanup] 1.0 RC4 was the original target milestone for this bug
Comment 4 Eclipse Webmaster CLA 2010-07-19 12:24:52 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime EMF was the original product and component for this bug