Bug 13507 - LinkedPositionUI has a reference to SWT.COLOR_RED
Summary: LinkedPositionUI has a reference to SWT.COLOR_RED
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Claude Knaus CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2002-04-11 09:30 EDT by Tod Creasey CLA
Modified: 2002-04-17 08:28 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2002-04-11 09:30:37 EDT 
LinkedPositionUI(ITextViewer, LinkedPositionManager) - 
org.eclipse.jdt.internal.ui.text.link.LinkedPositionUI has a reference to 
SWT.COLOR_RED which will be unreadble if the user sets their background colour 
to Red.

We will be adding a getErrorText colour to JFaceColours in build >20020411. You 
may want to use that.
Comment 1 Erich Gamma CLA 2002-04-12 08:35:11 EDT 
there should be a prefernce to change the template variable color
Comment 2 Tod Creasey CLA 2002-04-12 09:12:38 EDT 
There is now a JFaceColors entry getErrorText() which returns the JFace colour 
setting for errors. You may want to use this rather than creating another 
preference.
Comment 3 Claude Knaus CLA 2002-04-12 09:37:51 EDT 
It's not showing any errors, so I don't intend to use it. :)
Comment 4 Nick Edgar CLA 2002-04-16 09:57:24 EDT 
Please remove the ref to SWT.COLOR_RED if you're not using it then.
Comment 5 Claude Knaus CLA 2002-04-16 10:05:29 EDT 
I am using color red for now, that doesn't mean it is an error. I see that it's 
confusing because errors are now red, too. Therefore, I will change it to be 
configurable.
Comment 6 Nick Edgar CLA 2002-04-16 12:14:26 EDT 
The problem is that we need to avoid hardcoded colours for accessibility 
reasons. If it's configurable, that's OK.  
Please also describe how to cause this to occur so we can test for 
accessibility.
Comment 7 Claude Knaus CLA 2002-04-17 08:28:59 EDT 
fixed >= 20020417
added color preference option in Preference->Java->Editor