Comment 1 Michael Golubev 2006-04-06 02:23:43 EDT

This scr blocks #114061 that states (among other things): 

> Note, resize constraints are not yet taken from gmfgraph
> (gmfgraph.Node#resizeConstraints).

Comment 2 Michael Golubev 2006-04-06 05:46:03 EDT

Created attachment 37857 [details]
Fixes the subj

Please note that taipan sample should be recreated (the both recreation of the taipan.gmfgen and regeneration of the editor code is required). 

Unfortunately, I can not produce this myself, because there is some other waiting patches for taipan which is not yet committed.

Comment 3 Michael Golubev 2006-04-06 17:41:19 EDT

Created attachment 37944 [details]
Fixes the subj + tests + Direction.ALL as default direction constraint

This extends previous patch with tests and new functionality, which is implictly required. 
It allows nodes to be fully resizable by introducing new Direction.ALL into the gmfgraph model. The default value for gmfgraph.Node#direction is now set to ALL to confrom to the previous behavior.

Comment 4 Artem Tikhomirov 2006-04-10 08:34:48 EDT

Refactored and committed. Patch includes "not_implemented_scr_129362_testViewmapRequiredPluginIDs" which doesn't compile, thus was thrown away.

The bugzilla remains open to resolve next issue: gmfgraph.Node#resizeConstraint was intended to hold *constraint*, or *limitation* of resize operation, not resize *allowance* as it's implemented in the proposed patch. IOW, resizeConstraint == NONE means 'resize whatever you like", and "VERTICAL" means 'resize only in horizontal directions'. We should either change DirectionMapper (as a side note, we may wish to change the name as well ;) and default value of resizeConstraints to NONE instead of ALL, or to rename graphdef.Node#resizeConstraint to smth like resizeDirections.

Comment 5 Artem Tikhomirov 2006-04-14 10:33:00 EDT

Milestone updated.

Comment 6 Dmitry Stadnik 2006-04-20 04:38:43 EDT

In draw2d these constants are used to provide allowance so inverting their 
meaning in our model will lead to confusion. And it's more convenient to think 
about what we add rather than what we subtract since it's may be not obvious 
what we subtract from )))

Comment 7 Dmitry Stadnik 2006-04-20 04:59:43 EDT

-

Comment 8 Dmitry Stadnik 2006-04-20 08:30:15 EDT

-

Comment 9 Richard Gronback 2008-08-13 13:04:13 EDT

[target cleanup] 1.0 RC was the original target milestone for this bug

Comment 10 Eclipse Webmaster 2010-07-19 22:19:22 EDT

[GMF Restructure] Bug 319140 : product GMF and component
Generation was the original product and component for this bug