Comment 1 Michael Golubev 2006-04-06 01:27:59 EDT

Created attachment 37840 [details]
Fixes the subj

There are no simple ways to test this feature because fill/outline/etc propertis of erg.eclipse.draw2d.Shape class are private. 

Alsough, it may be tested by using tweaked RuntimeFQNSwitch() version that points to the mock implementation of the Shape class which allows to check these properties in runtime. Do we want to go this way?

Comment 2 Dmitry Stadnik 2006-04-06 11:08:15 EDT

There is no need to test this feature in runtime or write tricky eIsSet() checks. We just need a custom template for polygon (there is no sense in enabling filling for polylines) that will add explicit setFill(true) for the default fill=true value in the model for polygon figure.

Comment 3 Artem Tikhomirov 2006-04-10 07:27:44 EDT

Comment on attachment 37840 [details]
Fixes the subj

Patch includes fixes for TaiPan sample that won't be committed as part of this bugzilla.

Comment 4 Artem Tikhomirov 2006-04-10 07:28:33 EDT

The actual committed line is
%><%if (figureInstance instanceof Polyline ^ figureInstance.eIsSet(GMFGraphPackage.eINSTANCE.getShape_Fill())) {%>

Note 'xor', which seems better reflect the intention.

Comment 5 Richard Gronback 2008-08-13 13:07:32 EDT

[target cleanup] 1.0 M6 was the original target milestone for this bug

Comment 6 Eclipse Webmaster 2010-07-19 22:21:43 EDT

[GMF Restructure] Bug 319140 : product GMF and component
Generation was the original product and component for this bug