Bug 133668 - New option to 'Recreate Modified class files in Output Folder'
Summary: New option to 'Recreate Modified class files in Output Folder'
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M6   Edit
Assignee: Martin Aeschlimann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 133804 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-03-28 14:10 EST by Kent Johnson CLA
Modified: 2006-03-31 03:39 EST (History)
3 users (show)

See Also:

Attachments
Fix (1.49 KB, patch)
2006-03-30 06:09 EST, Markus Keller CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Johnson CLA 2006-03-28 14:10:39 EST 
Please see bug 129082.

JDT/Core has added a new option in M6 to JavaCore called CORE_JAVA_BUILD_MAKE_OUTPUT_FOLDER_CONSISTENT that needs to be surfaced in the UI.

From JavaCore.getDefaultOptions()
* BUILDER / Make Output Folder(s) Consistent
*    Indicate whether the JavaBuilder should check that the output folders
*    are consistent while performing incremental build operations. If changes
*    are detected to managed .class files, then a full build is performed.
*     - option id: "org.eclipse.jdt.core.builder.makeOutputFolderConsistent"
*     - possible values:   { "enabled", "ignore" }
*     - default:           "ignore"
Comment 1 Kent Johnson CLA 2006-03-28 14:57:51 EST 
Renamed the option to:

org.eclipse.jdt.core.builder.recreateModifiedClassFileInOutputFolder=enabled


BUILDER / Recreate Modified class files in Output Folder
Indicate whether the JavaBuilder should check for any changes to .class files
in the output folders while performing incremental build operations. If changes
are detected to managed .class files, then a full build is performed, otherwise
the changes are left as is. Tools further altering generated .class files, like optimizers, should ensure this option remains set in its default state of ignore.
Comment 2 Jerome Lanneluc CLA 2006-03-29 05:19:52 EST 
*** Bug 133804 has been marked as a duplicate of this bug. ***
Comment 3 Martin Aeschlimann CLA 2006-03-29 05:23:47 EST 
Any suggestions for the label in the prference page?

My suggestion would be:
'Detect and rebuild class files modified by others'
Comment 4 Martin Aeschlimann CLA 2006-03-29 05:24:58 EST 
Adding Philippe for brainstorming about the label.
Comment 5 Jerome Lanneluc CLA 2006-03-29 05:30:16 EST 
Maybe simply 'Rebuild class files modified by others' (detect is implicit)
Comment 6 Philipe Mulet CLA 2006-03-29 05:55:51 EST 
Both sounds good to me. Being a bit verbose there is likely a good idea.
The pref should go under the Java>Compiler>Building>Output folder area.
Comment 7 Martin Aeschlimann CLA 2006-03-29 09:09:51 EST 
new UI released > 20060329

used Jeromes suggestion 'Rebuild class files modified by others'
Comment 8 Markus Keller CLA 2006-03-30 04:05:10 EST 
Reopening. The preference is still enabled when I disable project-specific settings:

- default workspace setting ('Java Compiler > Building > Rebuild...' unchecked)
- set project-specific setting to checked
- change a class file in the text editor
    -> automatically recompiled (good)
- disable project-specific settings on 'Java Compiler > Building' page
- change a class file in the text editor
    -> automatically recompiled
    -> expected: no recompile
Comment 9 Martin Aeschlimann CLA 2006-03-30 04:17:04 EST 
Can you file a new bug against jdt.core?
Comment 10 Benno Baumgartner CLA 2006-03-30 05:35:24 EST 
verified in I20060330-0010

The option is there
Comment 11 Markus Keller CLA 2006-03-30 06:07:43 EST 
Problem is that UI does not remove the project-specific setting.
Comment 12 Markus Keller CLA 2006-03-30 06:09:27 EST 
Created attachment 37303 [details]
Fix
Comment 13 Markus Keller CLA 2006-03-30 10:45:09 EST 
Fixed UI problem in JavaBuildConfigurationBlock.
Filed bug 134064 for a core problem with the new feature.
Comment 14 Markus Keller CLA 2006-03-31 03:39:25 EST 
Verified in I20060330-2000.