Bug 133472 - Reconcile GenCompartment boolean properties
Summary: Reconcile GenCompartment boolean properties
Status: RESOLVED FIXED
Alias: None
Product: GMF-Tooling (ARCHIVED)
Classification: Modeling
Component: Core (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Michael Golubev CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-03-28 03:53 EST by Patrick Sodre CLA
Modified: 2010-07-19 22:20 EDT (History)
0 users

See Also:

Attachments
Fixes the subj + tests (13.16 KB, patch)
2006-03-28 15:52 EST, Michael Golubev CLA 		no flags Details | Diff
Additional patch that hopefully makes all compilable (1.97 KB, patch)
2006-03-29 01:29 EST, Michael Golubev CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Sodre CLA 2006-03-28 03:53:18 EST 
Version: EclipseCon Build.

Problem:
  After transforming gmfmap -> gmfgen, the List Layout option of a Compartment is replaced. This seems to indicate that this option is not being reconciled.
Expected behavior:
  The ListLayout option should have remained the same if it has been modified by the user.

To Reproduce:
  Create a Figure and have a compartment assigned to it.
  Create the gmfmap.
  Transform into gmfgen.
  Change the ListLayout to false.
  Re-transform gmfmap -> gmfgen.
  Inspect that the ListLayout is set back to true.

I can post an example if requested.
Comment 1 Michael Golubev CLA 2006-03-28 15:52:16 EST 
Created attachment 37141 [details]
Fixes the subj + tests
Comment 2 Michael Golubev CLA 2006-03-28 15:56:01 EST 
At least following set of properties has to be reconciled:

GenCompartment#listLayout
GenCompartment#canCollapse
GenCompartment#hideIfEmpty
GenCompartment#needsTitle
Comment 3 Michael Golubev CLA 2006-03-29 01:29:48 EST 
Created attachment 37179 [details]
Additional patch that hopefully makes all compilable
Comment 4 Artem Tikhomirov CLA 2006-03-30 11:59:11 EST 
reviewed and committed
Comment 5 Michael Golubev CLA 2006-03-30 12:02:53 EST 
Note: To determine the matching GenCompartment instance, reconciler checks the "title" property value. Thus, in the current version it is impossible to reconcile properties for compartment if user changes its title.
Comment 6 Eclipse Webmaster CLA 2010-07-19 22:20:43 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Generation was the original product and component for this bug