Description Brock Janiczak 2006-03-24 17:58:14 EST

Version: 3.2.0
Build id: I20060322-1335

A combo box to set the default suspend policy for new breakpoints was added to the JDT debug preference page.  This combo is missing the READ_ONLY style, allowing users to enter invalid values.  Attached is a patch to change the combo from a CCombo to a regular combo and use the read only style.

### Eclipse Workspace Patch 1.0
#P org.eclipse.jdt.debug.ui
Index: ui/org/eclipse/jdt/internal/debug/ui/JavaDebugPreferencePage.java
===================================================================
RCS file: /home/eclipse/org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/JavaDebugPreferencePage.java,v
retrieving revision 1.74
diff -u -r1.74 JavaDebugPreferencePage.java
--- ui/org/eclipse/jdt/internal/debug/ui/JavaDebugPreferencePage.java	14 Mar 2006 18:11:30 -0000	1.74
+++ ui/org/eclipse/jdt/internal/debug/ui/JavaDebugPreferencePage.java	24 Mar 2006 22:51:55 -0000
@@ -26,11 +26,11 @@
 import org.eclipse.jface.util.IPropertyChangeListener;
 import org.eclipse.jface.util.PropertyChangeEvent;
 import org.eclipse.swt.SWT;
-import org.eclipse.swt.custom.CCombo;
 import org.eclipse.swt.graphics.Font;
 import org.eclipse.swt.layout.GridData;
 import org.eclipse.swt.layout.GridLayout;
 import org.eclipse.swt.widgets.Button;
+import org.eclipse.swt.widgets.Combo;
 import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.Control;
 import org.eclipse.swt.widgets.Group;
@@ -75,7 +75,7 @@
 	private Button fSuspendDuringEvaluations;
 	private Button fOpenInspector;
 	private Button fPromptUnableToInstallBreakpoint;
-	private CCombo fSuspendVMorThread;
+	private Combo fSuspendVMorThread;
 	
 	// Hot code replace preference widgets
 	private Button fAlertHCRButton;
@@ -137,7 +137,7 @@
 		group.setLayoutData(data);
 		Label label = new Label(group, SWT.NONE);
 		label.setText(DebugUIMessages.JavaDebugPreferencePage_21);
-		fSuspendVMorThread = new CCombo(group, SWT.BORDER);
+		fSuspendVMorThread = new Combo(group, SWT.BORDER | SWT.READ_ONLY);
 		fSuspendVMorThread.setItems(new String[]{DebugUIMessages.JavaDebugPreferencePage_22, DebugUIMessages.JavaDebugPreferencePage_23});
 				
 		comp = createGroupComposite(composite, 1, DebugUIMessages.JavaDebugPreferencePage_Hot_Code_Replace_2);