Bug 132651 - Javadoc of CompletionContext#getTokenEnd() and CompletionProposal#getCompletionLocation are not correct.
Summary: Javadoc of CompletionContext#getTokenEnd() and CompletionProposal#getCompleti...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M6   Edit
Assignee: David Audel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-21 04:50 EST by David Audel CLA
Modified: 2006-03-28 10:23 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Audel CLA 2006-03-21 04:50:09 EST 
see bug 132558 comment 2.

When completion token is empty CompletionContext#getTokenEnd() isn't equals to getTokenStart() but to getTokenStart() minus one.
CompletionProposal#getCompletionLocation() isn't equals to offset parameter but to offset minus one.
Comment 1 David Audel CLA 2006-03-22 04:56:08 EST 
Fixed. Javadoc updated.
Comment 2 Olivier Thomann CLA 2006-03-28 10:23:42 EST 
Verified using I20060328-0010 for 3.2M6.
David, should we put ' - 1' for the CompletionProposal#getCompletionLocation() doc instead of ' minus one'?