Community
Participate
Working Groups
The validation preference page was updated in the 1.5 stream to allow individual validators to be disabled for the build or the manual validation option. When on the preference page I try to select to disable the XML validator for both build and manual validation. No options are presented. I can only change an option once I select the validator name "XML Validator". This is unintuitive for users. It appears as though the options cannot be changed. A user should be able to change any option by simply clicking on it. There does not seem to be any need to require them to click on the validator name before changing an option.
A second improvement (suggested by Valentin) is that clicking on the enabled/disabled image should toggle the switch.
Created attachment 36446 [details] Proposed patch Here's a patch which uses simulated check-boxes instead of the combo cell editors. The patch is not 100% done but I think it moves things in the right direction. To be completed: - improved icons if desired - provide different icons when a row is selected - provide different icons when the list is disabled I hope this helps. Regards, Valentin
Created attachment 36447 [details] New disabled icon
Created attachment 36448 [details] New enabled icon
Excellent improvement Valentin! The preference page is much more usable with this patch. I do agree that something needs to be done when the row is selected. The row currently turns blue and makes the checkboxes look greyed out and, for lack of a better word, crappy.
Valentin as you are fixing this defect it makes more sense to assign it to you. I will be on the CC and send me any new patches and i will review and commit them. Thanks
Opened https://bugs.eclipse.org/bugs/show_bug.cgi?id=133441 against SWT as it seems that the blury images when a row is selected may be a Table rendering issue. Trees seem to work OK.
I'm just going through the things that were to be done: - improved icons and disabled icons were provided as part of the fix for https://bugs.eclipse.org/bugs/show_bug.cgi?id=132228 - the explanation for the blurry icons when a row is selected is provided here https://bugs.eclipse.org/bugs/show_bug.cgi?id=133441. It appears that it is a platform behaviour to draw a shade around images in a table item. I wonder if we can consider this done and mark it as fixed? Or do we want to explore using a tree? The marker views (problems, tasks, etc) use a tree viewer and images seems to be painted nicely. See the attached screen shot.
Created attachment 37215 [details] Tasks screenshot
This patch is released for WTP 1.5 RC1.
Verified on WTP 1.5 RC6.
Closing bug.
