Bug 131355 - [Reconcile] Preserve user-modified values for attributes with model-coded defaults
Summary: [Reconcile] Preserve user-modified values for attributes with model-coded def...
Status: RESOLVED FIXED
Alias: None
Product: GMF-Tooling (ARCHIVED)
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Michael Golubev CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-03-10 13:02 EST by Michael Golubev CLA
Modified: 2010-07-19 22:17 EDT (History)
0 users

See Also:


Attachments
Initial simple implementation of the fix for subj (39.24 KB, patch)
2006-03-10 13:06 EST, Michael Golubev CLA
no flags Details | Diff
Fixed: reconciler fails to load old gmfgen resource when invoked from UI (39.09 KB, patch)
2006-03-10 14:01 EST, Michael Golubev CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Golubev CLA 2006-03-10 13:02:22 EST
Some reconciling strategy should be implemented like it is done for standard EMF GenModel.
Comment 1 Michael Golubev CLA 2006-03-10 13:06:43 EST
Created attachment 36070 [details]
Initial simple implementation of the fix for subj

The patch assumes that there are empty org.eclipse.gmf.codegen.reconciler and org.eclipse.gmf.codegen.reconciler.test.taipan plugins already created somewhere
Comment 2 Michael Golubev CLA 2006-03-10 13:12:49 EST
Attributes mostly often modified by user (like plugin id, provider name, ...) should be preserved. 
Comment 3 Michael Golubev CLA 2006-03-10 13:17:18 EST
Comment on attachment 36070 [details]
Initial simple implementation of the fix for subj

Proposed patch provides base extensible reconciler service. However, in the current service implementation, only small subset of features are supported. 
It will be extended in future
Comment 4 Michael Golubev CLA 2006-03-10 14:01:19 EST
Created attachment 36071 [details]
Fixed: reconciler fails to load old gmfgen resource when invoked from UI
Comment 5 Artem Tikhomirov CLA 2006-03-13 07:56:22 EST
There are attributes in gmfgen that are not set during transformation step and get their values from handcoded implementation. It's easy to detect user changes for such attributes, hence the patch.

Next attributes were identified as suitable for reconciling:
Copyright text
Package prefix
Diagram file extension
Same diagram/model file attribute
Plugin provider name
Plugin version

Please reopen scr to add more.
Comment 6 Artem Tikhomirov CLA 2006-03-13 08:00:24 EST
refactored into oeg.common/oeg.internal.common.reconcile package.
Tests: CodegenReconcileTest.
Comment 7 Eclipse Webmaster CLA 2010-07-19 22:17:34 EDT
[GMF Restructure] Bug 319140 : product GMF and component
Generation was the original product and component for this bug