Bug 130718 - [api][ltk][refactoring] Add new event type ADDED to RefactoringHistoryEvent
Summary: [api][ltk][refactoring] Add new event type ADDED to RefactoringHistoryEvent
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.2 M6   Edit
Assignee: Tobias Widmer CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2006-03-07 05:10 EST by Tobias Widmer CLA
Modified: 2006-03-07 09:50 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Widmer CLA 2006-03-07 05:10:29 EST 
Support has been added to the LTK to track and persist refactorings, in order to apply them later on other workspaces (see also bug 106207)

RefactoringHistoryEvent already has three events, PUSHED, POPPED, DELETED, which signal changes to the global refactoring history. A third event type ADDED could be avoided so far, but proofs to be necessary for listeners of the refactoring history in scenarios such as replace from repository, merge or update operations.

The proposed API addition is an additional constant:

/**
 * Event type indicating that a refactoring descriptor has been added to its
 * associated history (value 4)
 */
public static final int ADDED= 4;

The addition is non-breaking since the class RefactoringHistoryEvent is final.

Erich, do you approve?
Comment 1 Erich Gamma CLA 2006-03-07 05:26:45 EST 
+1
Comment 2 Tobias Widmer CLA 2006-03-07 05:29:58 EST 
Fixed in HEAD > 20060307
Available in build I20060307