Bug 129839 - Some remarks regarding the exercises in the teaching module
Summary: Some remarks regarding the exercises in the teaching module
Status: NEW
Alias: None
Product: AspectJ
Classification: Tools
Component: Docs (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: aspectj inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-28 14:41 EST by Daniel Le Berre CLA
Modified: 2006-02-28 14:41 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Le Berre CLA 2006-02-28 14:41:40 EST
I use the material available in the teaching module on CVS to introduce
AOP to my students. That's a really great material. Thanks for providing
it.

I like the "test driven approach" used in the exercises.

I have some small remarks that might improve the user experience:

- exercices 2a and 2d are manipulating both a negative input, thus the
expected behavior of the objets changes during the tutorial. I would
rather change the 2d to set a maximum value for the positive case. That
way, no need to deactivate aspect 2a and to disable test2a.

- the collections do not use generics: it might be worth updating the
code to avoid warnings for people using Java 5 now that aspectj is fully
Java 5 compliant.

- I would have preferred to have the data field in Log being private
final. But making it private  make it enter the following pointcut

set(private * *)&&!withincode(void set*(..))&&!(withincode(new(..)))
  
used to solve exercise 1c. Is there any way to say "and not within field
declaration initialization" in pointcuts?