Bug 129785 - Undo/redo doesn't work after making changes in property pages
Summary: Undo/redo doesn't work after making changes in property pages
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows 2000
: P1 critical
Target Milestone: 1.0   Edit
Assignee: Cherie Revells CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-28 09:54 EST by Cherie Revells CLA
Modified: 2018-10-09 10:45 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cherie Revells CLA 2006-02-28 09:54:46 EST 
After my EMF Transaction migration in the diagram layer, undo/redo no longer works when making changes in the properties view.
Comment 1 Cherie Revells CLA 2006-03-02 12:12:32 EST 
Linda debugged this.  The problem is that the diagram editor's operation history listener is receiving the event before the WorkspaceCommandStackImpl.DomainListener.  The DomainListener adds the context to the operation, so when the diagram editor's operation history listener gets the event there is no context set.

Transferring to Linda.
Comment 2 Cherie Revells CLA 2006-03-02 13:01:36 EST 
Purpose:   
Bugzilla#129785 Undo/redo doesn't work after making changes in property pages 
- Installed the operation history listener in the DiagramEditor.startListening() method instead of in its ctor. 

Activities:   
Bugzilla#129803 gmf_head cmahoney 060301 Deleting node leaves connection connected to space 

Code Reviewed by: 
Team programmed by:  Cherie, Christian, Linda. 

How tested: 
Adhoc property page undo/redo testing with multiple editors open. 

JUnit Tests:   
diagram.ui -- all passed
Comment 3 Richard Gronback CLA 2008-08-13 13:07:04 EDT 
[target cleanup] 1.0 M5 was the original target milestone for this bug
Comment 4 Eclipse Webmaster CLA 2010-07-19 12:30:27 EDT 
[GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug