Bug 129361 - Uninitialized fields in jdt/core code
Summary: Uninitialized fields in jdt/core code
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M6   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-24 10:57 EST by Benno Baumgartner CLA
Modified: 2006-03-27 15:39 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Benno Baumgartner CLA 2006-02-24 10:57:35 EST
I20060221-1300

I found following suspicious looking code in jdt/core while testing the new "Make 'final' where possible" Clean Up:

org.eclipse.jdt.internal.compiler.classfmt.ClassFormatException#fileName

This field is never written to, either it is not needed or 
ClassFormatException(RuntimeException e, char[] fileName) {
}
should set it.

org.eclipse.jdt.internal.compiler.ConfigurableOption#defaultValueIndex

This field seams not to be required.

org.eclipse.jdt.internal.formatter.Scribe2#lineEnds

This field is either not required or not initialized. Seams like it is not initialized.

You can see the problem when you change the fields in question to 'final'.
Comment 1 Olivier Thomann CLA 2006-02-24 13:31:43 EST
ConfigurableOptions is not used anymore, but I fixed it anyway.
Fixed org.eclipse.jdt.internal.compiler.classfmt.ClassFormatException and org.eclipse.jdt.internal.formatter.Scribe2.
Comment 2 Jerome Lanneluc CLA 2006-03-27 15:39:08 EST
Verified for 3.2 M6 using build I20060327-0010