Bug 129298 - Contribution: Remove Memory Consuming Declared Signature
Summary: Contribution: Remove Memory Consuming Declared Signature
Status: RESOLVED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: DEVELOPMENT   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 1.5.1   Edit
Assignee: Andrew Clement CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-24 03:45 EST by Ron Bodkin CLA
Modified: 2012-04-03 14:18 EDT (History)
0 users

See Also:

Attachments
weaver module patch to remove unneeded field & accessors (3.46 KB, patch)
2006-02-24 03:46 EST, Ron Bodkin CLA 		aclement: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ron Bodkin CLA 2006-02-24 03:45:34 EST 
The code for weaver.Member#getDeclaredSignature() is never used in the weaver. My memory analysis showed this can pin several megabytes of memory in a large system. This patch removes it. YAGNI :-)
Comment 1 Ron Bodkin CLA 2006-02-24 03:46:16 EST 
Created attachment 35291 [details]
weaver module patch to remove unneeded field & accessors
Comment 2 Andrew Clement CLA 2006-02-24 04:46:10 EST 
As the comment in the code says:

private final String declaredSignature; // TODO asc Is this redundant? Is it needed for generics?

And that 'asc' knows what he's talking about ;)
Comment 3 Andrew Clement CLA 2006-02-24 07:09:09 EST 
fix in.
Comment 4 Andrew Clement CLA 2006-03-27 15:24:16 EST 
done.