Community
Participate
Working Groups
RegistryStrategy#onStart(Object) RegistryStrategy#onStop(Object) When we had 2 different extension registries (one in the runtime namespace and the other in the equinox.registry namespace) these method signatures made sense. The registry code was refactored so now only one registry class exists. We should update the signatures for these methods accordingly to make things clearer for users of our new API. RegistryStrategy#onStart(IExtensionRegistry) RegistryStrategy#onStop(IExtensionRegistry) The only known callers of this method are internal to the registry. Since this change is happening after the API freeze, we need permission of the PMC to do this.
+1 from me. You might ping another PMC member for continuity.
Mike?
The change makes sense to me. If this interface is being treated as real API the javadoc comment about clients being repeatedly broken should be removed.
Agree with John's comment. You only need one PMC member's approval, so Jeff's +1 will carry it.
Created attachment 35331 [details] Patch for the org.eclipse.equinox.registry Patch modifies signatures of RegistryStrategy#onStart and RegistryStrategy#onStop as described in the request.
Patch released. re: javadoc - we have multiple places in the runtime that we need to re-visit w.r.t. provisional API. (including the registry classes)
