Bug 128977 - Adopt transaction API in diagram event broker API and CanonicalEditPolicy API
Summary: Adopt transaction API in diagram event broker API and CanonicalEditPolicy API
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows 2000
: P3 major
Target Milestone: 1.0   Edit
Assignee: Mohammed Mostafa CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2006-02-22 10:05 EST by Cherie Revells CLA
Modified: 2010-07-19 12:29 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Cherie Revells CLA 2006-02-22 10:05:56 EST
There is still work to be done in the diagram components to completely adopt the new EMF-Transaction API so we do not need the compatibility layer.

Specifically:
- How refreshSemanticChildren() and the CanonicalEditPolicy should be reworked so that any model changes (i.e. creation of new views) is done in response to a pre-commit event notification and refreshing of the UI (editparts, figures) is done in response to a post-commit event notification.
- Remove compatibiliy layer and make sure everything still works.
Comment 1 Cherie Revells CLA 2006-02-24 12:02:52 EST
Also to do:
- Move the code in DiagramEventBroker where the view is persisted to be in response to a pre-commit event.
Comment 2 Cherie Revells CLA 2006-02-28 10:56:48 EST
There is still changes that need to be done to NotationMetaModelProvider, NotationAdapterFactoryManager, etc.  I believe all this can be removed but there may be code in there that needs to be moved elsewhere.  Need to investigate.
Comment 3 Mohammed Mostafa CLA 2006-04-10 08:44:55 EDT
Fixed : 
the persist element handling had been moved to the pre-commit
no other changes are required caus ethe diagram editing domain noew allows starting write actions on the post=commit handling
Comment 4 Richard Gronback CLA 2008-08-13 13:07:22 EDT
[target cleanup] 1.0 M6 was the original target milestone for this bug
Comment 5 Eclipse Webmaster CLA 2010-07-19 12:29:59 EDT
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug